Clean up unused code in kubelet #109407
Merged
Clean up unused code in kubelet #109407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/kubelet
sig/node
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
aojea
reviewed
Apr 10, 2022
|
/retest-required |
|
/retest |
|
/assign @pohly he is the best person, or at least one of them to review this, |
|
/lgtm $ go run ./cmd/kubelet --logging-format=xyz
Flag --logging-format has been deprecated, This parameter should be set via the config file specified by the Kubelet's --config flag. See https://kubernetes.io/docs/tasks/administer-cluster/kubelet-config-file/ for more information.
E0411 10:06:00.034229 40869 run.go:74] "command failed" err="failed to validate kubelet configuration, error: logging.format: Invalid value: \"xyz\": Unsupported log format, path: &TypeMeta{Kind:,APIVersion:,}"
exit status 1It would be slightly nicer if that error wasn't reported with |
k8s-ci-robot
added
the
lgtm
|
@matthyx ping |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/assign @derekwaynecarr |
yxxhero
changed the title
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: yxxhero <aiopsclub@163.com>
yxxhero
force-pushed
the
remove_unused_code_in_kubelet
branch
from
b89b405
to
7a5af81
Compare
k8s-ci-robot
removed
lgtm
k8s-ci-robot
added
the
lgtm
|
@matthyx Thanks very much |
mrunalp
approved these changes
Jun 28, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cndoit18, matthyx, mrunalp, yxxhero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yxxhero aiopsclub@163.com
What type of PR is this?
Clean up unused code in kubelet
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes # None
Special notes for your reviewer: None
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: