Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmarking script for kube-proxy #117485

Closed
wants to merge 1 commit into from
Closed

benchmarking script for kube-proxy #117485

wants to merge 1 commit into from

Conversation

aroradaman
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #109481

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 19, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: daman1807
Once this PR has been reviewed and has the lgtm label, please assign andrewsykim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kube-proxy sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 19, 2023
BenTheElder
BenTheElder reviewed Apr 21, 2023
View reviewed changes
pkg/proxy/benchmarking/benchmark.sh Outdated Show resolved Hide resolved
pkg/proxy/benchmarking/benchmark.sh Show resolved Hide resolved
pkg/proxy/benchmarking/benchmark.sh Outdated Show resolved Hide resolved
pkg/proxy/benchmarking/benchmark.sh Outdated Show resolved Hide resolved
pkg/proxy/benchmarking/benchmark.sh Outdated Show resolved Hide resolved
pkg/proxy/benchmarking/benchmark.sh Outdated Show resolved Hide resolved
pkg/proxy/benchmarking/benchmark.sh Outdated Show resolved Hide resolved
@aroradaman aroradaman mentioned this pull request Apr 22, 2023
Open
@aroradaman
proxy/proxy: benchmarking framework
e794ac9 
Signed-off-by: Daman <aroradaman@gmail.com>
danwinship
danwinship reviewed May 8, 2023
View reviewed changes
pkg/proxy/benchmarking/bench_test.go
"-m tcp -p tcp",
"-d 10.96.11.12",
"--dport 8000",
"-j KUBE-SVC-QWERTY")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to benchmark just a single random rule. We want to benchmark the rules as the iptables proxier generates them, so that we can test things like "if I make such-and-such change to how externalTrafficPolicy: Local services work, does that regress in performance?"

Even though the functions we're testing are in utilproxy, I think the benchmark will be in pkg/proxy/iptables, because that's mostly what we want to benchmark. We want (at least) a benchmark that is similar to TestOverallIPTablesRulesWithMultipleServices.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
@aroradaman
Copy link
Member Author

/close

@k8s-ci-robot
Copy link
Contributor

@aroradaman: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwinship danwinship danwinship left review comments

@BenTheElder BenTheElder BenTheElder left review comments

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@caseydavenport caseydavenport Awaiting requested review from caseydavenport

Assignees
No one assigned
Labels
area/kube-proxy cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need benchmarks for iptables proxy golang performance hacks
5 participants
@aroradaman @k8s-ci-robot @k8s-triage-robot @danwinship @BenTheElder