add test case for ToValidOperationID method: TestToValidOperationID

[twilight0620]

What type of PR is this?

add test case for ToValidOperationID method: TestToValidOperationID

Add one of the following kinds:
/kind cleanup

What this PR does / why we need it:

ToValidOperationID method does not has ut test, so i add it.

Which issue(s) this PR fixes:

add ut test

Special notes for your reviewer:

Does this PR introduce a user-facing change?

  NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[k8s-ci-robot]

Please note that we're already in Test Freeze for the release-1.24 branch. This means every merged PR has to be cherry-picked into the release branch to be part of the upcoming v1.24.0 release.

[k8s-ci-robot]

Hi @twilight0620. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yxxhero]

/ok-to-test

[twilight0620]

pull-kubernetes-verify

@yxxhero hi, i see some checks were not successful, but i did not see errors about my ut code, does the failures caused by my code? what should i modify?

[yxxhero]

/retest-required

[yxxhero]

@twilight0620 #109690 (comment)

[twilight0620]

/retest-required

[leilajal]

/assign @Jefftree @apelisse
/triage accepted

[apelisse]

/assign @Jefftree

Do you want to look at this?

[Jefftree]

@twilight0620 Since we're adding tests to improve the coverage, can we add test cases to exercise all code paths of the function?

(Add cases for names with underscore and numbers https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/openapi/openapi.go#L47)

Thank you!

[Jefftree]

/unassign @apelisse

[twilight0620]

@twilight0620 Since we're adding tests to improve the coverage, can we add test cases to exercise all code paths of the function?

(Add cases for names with underscore and numbers https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/openapi/openapi.go#L47)

Thank you!

ok, i have added it.

[twilight0620]

/retest-required

[Jefftree]

@twilight0620 Since we're adding tests to improve the coverage, can we add test cases to exercise all code paths of the function?
(Add cases for names with underscore and numbers https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/openapi/openapi.go#L47)
Thank you!

ok, i have added it.

Sorry if I wasn't very clear, you don't need to add a separate test case for those behaviors in isolation. Bundling them with one of the other test cases should be fine.

[twilight0620]

@twilight0620 Since we're adding tests to improve the coverage, can we add test cases to exercise all code paths of the function?
(Add cases for names with underscore and numbers https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/endpoints/openapi/openapi.go#L47)
Thank you!

ok, i have added it.

Sorry if I wasn't very clear, you don't need to add a separate test case for those behaviors in isolation. Bundling them with one of the other test cases should be fine.

you mean add scenarios like abc_abc and abc33abc?

[twilight0620]

/retest-required

[twilight0620]

could anyone handle and merge this pr？

[apelisse]

gentle ping @Jefftree

[Jefftree]

/lgtm

[Jefftree]

/assign @sttts

[twilight0620]

gentle ping @sttts

[twilight0620]

/assign @smarterclayton

[sttts]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sttts, twilight0620

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiserver/OWNERS [sttts]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest