Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ioutil in kubelet #109692

Merged
merged 1 commit into from Jun 3, 2022
Merged

remove ioutil in kubelet #109692

merged 1 commit into from Jun 3, 2022

Conversation

yxxhero
Copy link
Member

@yxxhero yxxhero commented Apr 27, 2022

Signed-off-by: yxxhero aiopsclub@163.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

remove ioutil in kubelet

Which issue(s) this PR fixes:

Fixes # NONE

Special notes for your reviewer:

NONE

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 27, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.24 branch. This means every merged PR has to be cherry-picked into the release branch to be part of the upcoming v1.24.0 release.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 27, 2022
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 27, 2022
@yxxhero
Copy link
Member Author

yxxhero commented Apr 27, 2022

/sig node

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 27, 2022
@yxxhero yxxhero marked this pull request as draft April 27, 2022 11:17
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2022
@yxxhero yxxhero marked this pull request as ready for review April 27, 2022 11:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 27, 2022
@yxxhero
remove ioutil in kubelet
4fac748 
Signed-off-by: yxxhero <aiopsclub@163.com>
endocrimes
endocrimes reviewed May 4, 2022
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/triage accepted
/priority backlog

I'm generally wary of sweeping changes, but ioutil to os should be pretty safe

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 4, 2022
@endocrimes endocrimes moved this from Triage to Needs Approver in SIG Node PR Triage May 4, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2022
@dims
Copy link
Member

dims commented Jun 3, 2022

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, yxxhero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit 60902b7 into kubernetes:master Jun 3, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Jun 3, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 3, 2022
@yxxhero yxxhero deleted the remove_ioutil_in_kubelet branch June 3, 2022 23:31
@inosato inosato mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes left review comments

@cndoit18 cndoit18 cndoit18 left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

Assignees

@endocrimes endocrimes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yxxhero @k8s-ci-robot @dims @endocrimes @cndoit18