Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kubectl doc url #109824

Merged
merged 1 commit into from May 13, 2022
Merged

update kubectl doc url #109824

merged 1 commit into from May 13, 2022

Conversation

my-git9
Copy link
Member

@my-git9 my-git9 commented May 5, 2022 •
edited

/kind cleanup

The url about kubectl 'https://kubernetes.io/docs/reference/kubectl/overview/' has been changed to 'https://kubernetes.io/docs/reference/kubectl/', I think we shoud change it in code

@my-git9
update kubectl doc url
e89a87f 
Signed-off-by: xin.li <xin.li@daocloud.io>
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 5, 2022
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 5, 2022
@my-git9
Copy link
Member Author

my-git9 commented May 5, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 5, 2022
@my-git9
Copy link
Member Author

my-git9 commented May 5, 2022

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 5, 2022
@my-git9
Copy link
Member Author

my-git9 commented May 5, 2022

/assign @brianpursley

@ardaguclu
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2022
@my-git9
Copy link
Member Author

my-git9 commented May 5, 2022

/retest

@my-git9
Copy link
Member Author

my-git9 commented May 5, 2022

/test pull-kubernetes-integration

@ardaguclu
Copy link
Member

I think, we need to wait until integration test is stable again which is traced in here #109783 (comment)

brianpursley
brianpursley approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@brianpursley brianpursley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianpursley, my-git9

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 00f829b into kubernetes:master May 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone May 13, 2022
sftim
sftim reviewed Jun 25, 2022
View reviewed changes
staging/src/k8s.io/kubectl/pkg/cmd/cmd.go
@@ -258,7 +258,7 @@ func NewKubectlCommand(o KubectlOptions) *cobra.Command {
kubectl controls the Kubernetes cluster manager.

Find more information at:
https://kubernetes.io/docs/reference/kubectl/overview/`),
https://kubernetes.io/docs/reference/kubectl/`),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late aside: https://k8s.io/docs/reference/kubectl/ also works.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to use a short URL such as https://k8s.io/kubectl-reference, file a feature request against k/website - it's easy enough to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@brianpursley brianpursley brianpursley approved these changes

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@brianpursley brianpursley

@ardaguclu ardaguclu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@my-git9 @ardaguclu @k8s-ci-robot @brianpursley @sftim