-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating base container image for pause image on Windows #110379
Updating base container image for pause image on Windows #110379
Conversation
After we finalize the process for how to consume an intermediate layer for the Windows pause image we can do a proper fix for this hack kubernetes/build/pause/Dockerfile_windows Lines 21 to 24 in 4988bfc
by cleanly disabling the service during the windows-pause-image-base build.
I suspect there are a number of other services we can disable to improve pod startup time |
I built https://hub.docker.com/r/mrosse3/pause/tags with these changes |
Does this need any release note? I'd expect one. |
/approve |
@marosset please update |
/hold |
I'll add one. |
6a0250a
to
3ce843d
Compare
/triage accepted |
Done (and I updated CHANGELOG.md too) |
3ce843d
to
e6058f4
Compare
Added! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, marosset The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold Let me address #110379 (comment) and bump the new pause image version before this merges |
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
e6058f4
to
5375102
Compare
We released another version of the pause base image that has the diagtrack service disabled. Also not that the new base images have notary signatures! |
@marosset LGTM |
/lgtm |
Looks good, /lgtm |
/hold cancel |
Here is the manifest that got pushed as a result of the Looks good to me! |
Signed-off-by: Mark Rossetti marosset@microsoft.com
What type of PR is this?
/kind feature
What this PR does / why we need it:
The PR updates the base image used to build the Windows pause container images to an image that has some registry changes.
We are using an intermediate container image that is built on a Windows machine because Windows registry changes do not 'stick' when the images are built with buildkit. (more details in #109161)
Which issue(s) this PR fixes:
Fixes #109161
Special notes for your reviewer:
Please see #109161 and https://github.com/microsoft/windows-pause-image-base for details on why this is neccessary.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig windows