support fieldSelector spec.hostNetwork #110477

halfcrazy · 2022-06-09T04:45:29Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add support for pod hostNetwork field selector, it may helpful for the network operator to filter pod.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added support for pod `hostNetwork` field selector

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2022-06-09T04:45:37Z

Hi @halfcrazy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

aojea · 2022-06-09T05:35:02Z

/sig api-machinery

pacoxu · 2022-06-09T09:03:09Z

I find a workaround here #88530 (comment).
--field-selector="spec.nodeName=<NodeName>,status.podIP!=<NodeIP>"

/cc @liggitt

leilajal · 2022-06-09T16:42:36Z

/sig node
/remove-sig api-machinery

k8s-triage-robot · 2022-09-07T17:04:21Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

halfcrazy · 2022-09-09T01:40:25Z

/remove-lifecycle stale

k8s-triage-robot · 2022-12-08T01:41:15Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

halfcrazy · 2022-12-08T06:01:18Z

/remove-lifecycle stale

bart0sh · 2023-02-10T07:32:11Z

/triage accepted
/priority backlog
/ok-to-test
/assign @aojea @thockin

thockin · 2023-03-13T22:09:51Z

pkg/apis/core/v1/conversion.go

@@ -41,11 +41,14 @@ func addConversionFuncs(scheme *runtime.Scheme) error {
 				"spec.restartPolicy",
 				"spec.schedulerName",
 				"spec.serviceAccountName",
+				"spec.securityContext.hostNetwork",


I don't understand - this is not a real field in v1. It's just spec.hostNetwork. The internal name doesn't matter.

thockin · 2023-03-13T22:13:23Z

pkg/registry/core/pod/strategy.go

 	podSpecificFieldsSet["spec.nodeName"] = pod.Spec.NodeName
 	podSpecificFieldsSet["spec.restartPolicy"] = string(pod.Spec.RestartPolicy)
 	podSpecificFieldsSet["spec.schedulerName"] = string(pod.Spec.SchedulerName)
 	podSpecificFieldsSet["spec.serviceAccountName"] = string(pod.Spec.ServiceAccountName)
+	if pod.Spec.SecurityContext != nil {
+		podSpecificFieldsSet["spec.securityContext.hostNetwork"] = strconv.FormatBool(pod.Spec.SecurityContext.HostNetwork)


Just spec.hostNetwork

thockin · 2023-04-14T20:28:40Z

Pinging on this one. Open questions prevent it from being accepted yet.

halfcrazy · 2023-04-15T09:30:16Z

Pinging on this one. Open questions prevent it from being accepted yet.

Update

halfcrazy · 2023-04-15T10:41:19Z

/retest

aojea · 2023-04-15T18:23:29Z

/cc @wojtek-t

it will be good to understand if this present an scalability problem and the net value is worth it

pkg/registry/core/pod/strategy.go

pkg/registry/core/pod/strategy_test.go

halfcrazy · 2023-04-17T02:14:17Z

/retest

Signed-off-by: Yan Zhu <hackzhuyan@gmail.com>

thockin

Thanks!

/lgtm
/approve

k8s-ci-robot · 2023-04-21T23:46:28Z

LGTM label has been added.

Git tree hash: d580bec3ec5c932a9f19dc835f71916aab81ebd0

k8s-ci-robot · 2023-04-21T23:46:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: halfcrazy, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/apis/OWNERS~~ [thockin]
~~pkg/registry/OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from caesarxuchao and wojtek-t June 9, 2022 04:46

k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 9, 2022

k8s-ci-robot requested a review from liggitt June 9, 2022 09:03

k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 9, 2022

SergeyKanzhelev added this to Triage in SIG Node PR Triage Jun 13, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2022

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 8, 2022

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 10, 2023

k8s-ci-robot assigned aojea Feb 10, 2023

k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 10, 2023

k8s-ci-robot assigned thockin Feb 10, 2023

bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Feb 10, 2023

thockin reviewed Mar 13, 2023

View reviewed changes

halfcrazy force-pushed the feat/hostnetwork-fieldsel branch from 74d2da4 to 1d49157 Compare April 15, 2023 10:40

aojea reviewed Apr 15, 2023

View reviewed changes

pkg/registry/core/pod/strategy.go Show resolved Hide resolved

thockin reviewed Apr 16, 2023

View reviewed changes

pkg/registry/core/pod/strategy_test.go Show resolved Hide resolved

support fieldSelector spec.hostNetwork

7fb88ee

Signed-off-by: Yan Zhu <hackzhuyan@gmail.com>

halfcrazy force-pushed the feat/hostnetwork-fieldsel branch from d6be85a to 7fb88ee Compare April 17, 2023 05:20

halfcrazy requested a review from thockin April 19, 2023 13:58

thockin reviewed Apr 21, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2023

k8s-ci-robot merged commit 25a25e2 into kubernetes:master Apr 22, 2023
12 checks passed

SIG Node PR Triage automation moved this from Needs Reviewer to Done Apr 22, 2023

k8s-ci-robot added this to the v1.28 milestone Apr 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support fieldSelector spec.hostNetwork #110477

support fieldSelector spec.hostNetwork #110477

halfcrazy commented Jun 9, 2022 •

edited

k8s-ci-robot commented Jun 9, 2022

aojea commented Jun 9, 2022

pacoxu commented Jun 9, 2022

leilajal commented Jun 9, 2022

k8s-triage-robot commented Sep 7, 2022

halfcrazy commented Sep 9, 2022

k8s-triage-robot commented Dec 8, 2022

halfcrazy commented Dec 8, 2022

bart0sh commented Feb 10, 2023

thockin Mar 13, 2023

halfcrazy Apr 15, 2023

thockin Mar 13, 2023

halfcrazy Apr 15, 2023

thockin commented Apr 14, 2023

halfcrazy commented Apr 15, 2023

halfcrazy commented Apr 15, 2023

aojea commented Apr 15, 2023

halfcrazy commented Apr 17, 2023

thockin left a comment

k8s-ci-robot commented Apr 21, 2023

k8s-ci-robot commented Apr 21, 2023

support fieldSelector spec.hostNetwork #110477

support fieldSelector spec.hostNetwork #110477

Conversation

halfcrazy commented Jun 9, 2022 • edited

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Jun 9, 2022

aojea commented Jun 9, 2022

pacoxu commented Jun 9, 2022

leilajal commented Jun 9, 2022

k8s-triage-robot commented Sep 7, 2022

halfcrazy commented Sep 9, 2022

k8s-triage-robot commented Dec 8, 2022

halfcrazy commented Dec 8, 2022

bart0sh commented Feb 10, 2023

thockin Mar 13, 2023

Choose a reason for hiding this comment

halfcrazy Apr 15, 2023

Choose a reason for hiding this comment

thockin Mar 13, 2023

Choose a reason for hiding this comment

halfcrazy Apr 15, 2023

Choose a reason for hiding this comment

thockin commented Apr 14, 2023

halfcrazy commented Apr 15, 2023

halfcrazy commented Apr 15, 2023

aojea commented Apr 15, 2023

halfcrazy commented Apr 17, 2023

thockin left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 21, 2023

k8s-ci-robot commented Apr 21, 2023

halfcrazy commented Jun 9, 2022 •

edited