Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write patchCoreV1NamespacedPodStatus test - +1 endpoint #110705

Merged
merged 1 commit into from Jun 27, 2022
Merged

Write patchCoreV1NamespacedPodStatus test - +1 endpoint #110705

merged 1 commit into from Jun 27, 2022

Conversation

Riaankl
Copy link
Contributor

@Riaankl Riaankl commented Jun 21, 2022 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:

  • patchCoreV1NamespacedPodStatus

Which issue(s) this PR fixes:
Fixes #108499

Testgrid Link:
Testgrid

Special notes for your reviewer:
Adds +1 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/area conformance
/sig node

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/node Categorizes an issue or PR as relevant to SIG Node. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 21, 2022
@Riaankl
Copy link
Contributor Author

Riaankl commented Jun 21, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 21, 2022
@Riaankl Riaankl added this to Test PRs Needing Approval in conformance-definition Jun 21, 2022
xmcqueen
xmcqueen reviewed Jun 22, 2022
View reviewed changes
Copy link
Contributor

@xmcqueen xmcqueen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@heyste
Copy link
Member

heyste commented Jun 22, 2022

/test pull-kubernetes-e2e-kind
unrelated flake

@pacoxu pacoxu added this to Triage in SIG Node PR Triage Jun 24, 2022
@Riaankl
Copy link
Contributor Author

Riaankl commented Jun 26, 2022

Thank you for adding this to the SIG Node Project board!! @endocrimes @pacoxu

To meet the conformance criteria we need to merge this e2e test and let it soak flake free for 2 weeks on the test grid, where after we would create the Promotion PR. (We have 6 weeks before test freeze.)
We have several e2e tests PRs with different SIG, and I am following up on all of them to ensure we do not have PRs left behind.
Is there anyone I should as /assign to help us move this endpoint to conformance before test freeze?

@dims
Copy link
Member

dims commented Jun 26, 2022

/assign @endocrimes

endocrimes
endocrimes approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold

minor nit, feel free to fix and then me/another reviewer can unhold/lgtm or unhold and follow up when promoting.

test/e2e/common/node/pods.go Outdated
pStatus, err := podClient.Patch(context.TODO(), podName, types.MergePatchType,
[]byte(`{"metadata":{"annotations":{"patchedstatus":"true"}},"status":`+string(pStatusJSON)+`}`),
metav1.PatchOptions{}, "status")
framework.ExpectNoError(err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
framework.ExpectNoError(err)
framework.ExpectNoError(err, "failed to patch pod: %q", podName)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@endocrimes Fixed this nit now as the promote process has set requirements around no other modifications to test source code in the PR.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 27, 2022
@heyste
Create e2e test for PodStatus endpoint
bc22560 
e2e test validates the following endpoint
- patchCoreV1NamespacedPodStatus
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 27, 2022
endocrimes
endocrimes approved these changes Jun 27, 2022
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/unhold

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: endocrimes, Riaankl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6ed938f into kubernetes:master Jun 27, 2022
conformance-definition automation moved this from Test PRs Needing Approval to Done Jun 27, 2022
SIG Node CI/Test Board automation moved this from Triage to Done Jun 27, 2022
SIG Node PR Triage automation moved this from Triage to Done Jun 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 27, 2022
@Riaankl Riaankl moved this from Done to Promotion PRs Needing Two Weeks (flake free) in conformance-definition Jun 28, 2022
@Riaankl Riaankl mentioned this pull request Jun 28, 2022
Closed
6 tasks
@Riaankl Riaankl moved this from Promotion PRs Needing Two Weeks (flake free) to Done in conformance-definition Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyste heyste heyste left review comments

@xmcqueen xmcqueen xmcqueen left review comments

@endocrimes endocrimes endocrimes approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@endocrimes endocrimes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
conformance-definition
  
Done
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.

Revised Update patchCoreV1NamespacedPodStatus test - +1 endpoint coverage
6 participants
@Riaankl @heyste @dims @k8s-ci-robot @endocrimes @xmcqueen