Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SIG Scheduling approvers from reviewers #111004

Merged
merged 1 commit into from Jul 7, 2022

Conversation

alculquicondor
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

/sig scheduling

We currently have 4 approvers and 8 reviewers (including the 4 approvers)

I propose:

  • To remove the approvers from the reviewers list (this PR)
  • Any PR should be reviewed by a reviewer before being assigned to the approver. Reviewers are assigned automatically.
  • If it's a hotfix, the PR can be assigned to an approver directly.

I hope this accomplishes the following:

  • Lower review burden from approvers
  • Encourage our reviewers to take more responsibility and build their reputation.
  • Encourage new contributors to seek the reviewer status.

Original proposal https://groups.google.com/g/kubernetes-sig-scheduling/c/1JD2w1w48uo/

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 7, 2022
@k8s-ci-robot
Copy link
Contributor

@alculquicondor: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jul 7, 2022
@alculquicondor
Copy link
Member Author

Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, good idea to get more reviewers active. Thanks Aldo!

@denkensk
Copy link
Member

denkensk commented Jul 7, 2022

+1

@ahg-g
Copy link
Member

ahg-g commented Jul 7, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2022
@Huang-Wei
Copy link
Member

+1, thanks Aldo for driving this.

@alculquicondor
Copy link
Member Author

/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Jul 7, 2022

/approve
per acks from scheduling leads

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, damemi, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2022
@k8s-ci-robot k8s-ci-robot merged commit e9b96b1 into kubernetes:master Jul 7, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants