New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable stylecheck check in golangci #111101
Conversation
@Abirdcfly: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
/assign @thockin |
/sig testing |
I like it. Obviously it needs #109639 /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Abirdcfly, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
/test pull-kubernetes-verify |
/retest |
Signed-off-by: Abirdcfly fp544037857@gmail.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
I noticed that there are some related pr to fix the duplicate import issue, and we can fix it earlier by adding detection to golangci-lint.
#109639 should fix all old issue. Add detection to golangci to avoid later problems.
Which issue(s) this PR fixes:
Special notes for your reviewer:
source
As far as I know, k8s does not use this feature.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: