refactor the reflector to pave the way for streaming #111176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/assign @wojtek-t |
wojtek-t
reviewed
Jul 15, 2022
| if watchDuration < 1*time.Second && eventCount == 0 { | ||
| return fmt.Errorf("very short watch: %s: Unexpected watch close - watch lasted less than a second and no items received", r.name) | ||
| return fmt.Errorf("very short watch: %s: Unexpected watch close - watch jasted less than a second and no items received", name) |
| @@ -254,111 +254,10 @@ func (r *Reflector) resyncChan() (<-chan time.Time, func() bool) { | |||
| func (r *Reflector) ListAndWatch(stopCh <-chan struct{}) error { | |||
| klog.V(3).Infof("Listing and watching %v from %s", r.expectedTypeName, r.name) | |||
| var resourceVersion string | |||
| var err error | |||
There was a problem hiding this comment.
nit - just remove this line and the above and do:
resourceVersion, err := r.list(stopCh)
below :)
| errc chan error, | ||
| stopCh <-chan struct{}, | ||
| ) error { | ||
| resourceVersion := "" |
There was a problem hiding this comment.
Let's remove and just create this var in every loop below as it was - I think it would be more intuitive.
p0lyn0mial
force-pushed
the
upstream-cacher-refactor-for-streaming
branch
from
fc67721
to
63b125d
Compare
|
@wojtek-t pushed, ptal, thx. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This is a no-op PR. It paves the way for #110772.
It extracts shared functionality into a separate function (
watchHandler) and moves a list call into its own method.Which issue(s) this PR fixes:
xref: #110772
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: