Fix incorrect message when attaching to ephemeral containers #111185
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
release-note-none
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
| return "" | ||
| } | ||
| if _, path := podcmd.FindContainerByName(o.Pod, containerName); strings.HasPrefix(path, "spec.ephemeralContainers") { | ||
| return fmt.Sprintf("Session ended, the ephemeral container will not be restarted but may be reattached using '%s %s -c %s -i -t' if it is still running", o.CommandName, o.Pod.Name, containerName) |
There was a problem hiding this comment.
In which circumstances ephemeral container can be reattached?, because all of the cases I tried, it failed.
Is it because I exited from ephemeral container by typingexit?
Wouldn't be better(or possible) to state that: is reattachment going to work or not instead "may not"?
There was a problem hiding this comment.
Yes, typing exit means that the container is no longer running. If you disconnect while the process is still running (for example, because of a network reset or by killing kubectl) then you can reattach.
| // reattachMessage returns a message to print after attach has completed, or | ||
| // the empty string if no message should be printed. | ||
| func (o *AttachOptions) reattachMessage(containerName string, rawTTY bool) string { | ||
| if o.Quiet || !o.Stdin || !rawTTY || o.Pod.Spec.RestartPolicy != corev1.RestartPolicyAlways { |
There was a problem hiding this comment.
Just for learning; why we added !rawTTY in here?
There was a problem hiding this comment.
Just because that's the current behavior.
|
/retest |
Co-authored-by: Akanksha kumari <akankshakumari393@gmail.com>
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianpursley, verb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What type of PR is this?
/kind bug
/sig cli
/priority important-longterm
What this PR does / why we need it:
kubectl prints reconnect instructions after a
kubectl attachsession ends, but this is misleading for ephemeral containers because they won't be restarted and the attach will fail.Which issue(s) this PR fixes:
Fixes #111027
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: