-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSA is very inefficient with huge number of labels/annotations/... #111215
Comments
/cc |
/cc @Jefftree @alexzielenski |
We took a quick look at that, we know why it happens. The fix is not trivial, and while I wish fixing this would improve the overall performance, I don't know if it will be better for small maps/lists. We'll keep that in mind though, this is pretty terrible. |
@apelisse - thanks! |
/cc |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
This issue has not been updated in over 1 year, and should be re-triaged. You can:
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/ /remove-triage accepted |
/triage accepted |
As shown here:
https://github.com/kubernetes/kubernetes/pull/110569/files#diff-c9661ce6b32ebf6604536c747826c618fa7d057248f4dffe11d576063a3b480bR358-R363
SSA (computing ManagedFields) is highly inefficient for huge number of labels/annotations and with high enough numbers (the original test had 130,000 labels) could easily exceed 10s.
As pointed in the comment thread there, I don't perceive it as a top priority as it doesn't seem to be a usecase that is really used in production usecases, but it's probably worth discussing that explicitly and making a conscious decision.
/sig api-machinery
/priority important-longterm
/kind bug
@apelisse
@aojea - FYI
The text was updated successfully, but these errors were encountered: