-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote APIService lifecycle test + 4 Endpoints #111263
Promote APIService lifecycle test + 4 Endpoints #111263
Conversation
/triage accepted |
/test pull-kubernetes-conformance-kind-ipv6-parallel Unreleated flake
|
/priority important-soon |
/test pull-kubernetes-e2e-gce-ubuntu-containerd Unrelated flake
|
/test pull-kubernetes-conformance-image-test Unreleated flake
|
/assign @johnbelamaric @smarterclayton |
/approve |
/approve Caveat recorded here that this may have admin-visible stability implications (because APIService can impact client programs), so if a significant amount of conformers complain we may have to mitigate. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, Riaankl, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think we should revert this |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:
Which issue(s) this PR fixes:
Fixes #110236
Testgrid Link:
Testgrid
Special notes for your reviewer:
Adds +4 endpoint test coverage (good for conformance)
Does this PR introduce a user-facing change?:
Release note:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig testing
/sig architecture
/area conformance