Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote APIService lifecycle test + 4 Endpoints #111263

Merged

Conversation

riaankleinhans
Copy link
Contributor

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:

  • replaceApiregistrationV1APIServiceStatus
  • replaceApiregistrationV1APIService
  • patchApiregistrationV1APIServiceStatus
  • deleteApiregistrationV1CollectionAPIService

Which issue(s) this PR fixes:
Fixes #110236

Testgrid Link:
Testgrid

Special notes for your reviewer:
Adds +4 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 19, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jul 19, 2022
@riaankleinhans riaankleinhans added this to Promotion PRs Needing Approval in conformance-definition Jul 19, 2022
@riaankleinhans
Copy link
Contributor Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 19, 2022
@riaankleinhans
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ipv6-parallel

Unreleated flake

 Jul 19 23:13:03.100: FAIL: failed to locate replicaset test-rs in namespace replicaset-570: watch closed before UntilWithoutRetry timeout

@riaankleinhans
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 19, 2022
@riaankleinhans
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

Unrelated flake

[sig-storage] CSI Volumes [Driver: csi-hostpath] [Testpattern: Dynamic PV (block volmode)(allowExpansion)] volume-expand should resize volume when PVC is edited while pod is using it
I0719 23:50:47.584] test/e2e/storage/testsuites/volume_expand.go:252
I0719 23:50:47.584] ------------------------------
I0719 23:50:48.249] 
I0719 23:50:48.250] Ran 849 of 7051 Specs in 1769.352 seconds
I0719 23:50:48.251] FAIL! -- 848 Passed | 1 Failed | 0 Pending | 6202 Skipped

@riaankleinhans
Copy link
Contributor Author

/test pull-kubernetes-conformance-image-test

Unreleated flake

I0720 00:46:34.510] {"msg":"PASSED [sig-scheduling] SchedulerPreemption [Serial] PreemptionExecutionPath runs ReplicaSets to verify preemption running path [Conformance]","completed":23,"skipped":434,"failed":0}

@riaankleinhans
Copy link
Contributor Author

/assign @johnbelamaric @smarterclayton

@dims
Copy link
Member

dims commented Jul 20, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 20, 2022
@smarterclayton
Copy link
Contributor

smarterclayton commented Jul 21, 2022

/approve

Caveat recorded here that this may have admin-visible stability implications (because APIService can impact client programs), so if a significant amount of conformers complain we may have to mitigate.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Riaankl, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2022
@k8s-ci-robot k8s-ci-robot merged commit 398a67c into kubernetes:master Jul 21, 2022
conformance-definition automation moved this from Promotion PRs Needing Approval to Done Jul 21, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 21, 2022
@aojea
Copy link
Member

aojea commented Jul 22, 2022

/approve

Caveat recorded here that this may have admin-visible stability implications (because APIService can impact client programs), so if a significant amount of conformers complain we may have to mitigate.

I think we should revert this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

Successfully merging this pull request may close these issues.

Write APIService lifecycle test + 4 Endpoints
7 participants