Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e to validate stats for Windows hostprocess containers #111332

Merged
merged 1 commit into from Oct 21, 2022
Merged

Add e2e to validate stats for Windows hostprocess containers #111332

merged 1 commit into from Oct 21, 2022

Conversation

marosset
Copy link
Contributor

Signed-off-by: Mark Rossetti marosset@microsoft.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Add e2e to validate stats for Windows hostprocess containers

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig windows

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 21, 2022
@marosset
Copy link
Contributor Author

/assign @jsturtevant

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2022
@jsturtevant
Copy link
Contributor

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 22, 2022
@jsturtevant
Copy link
Contributor

This will require a fix in hcsshim to pass: microsoft/hcsshim#1465

@marosset
Copy link
Contributor Author

This will require a fix in hcsshim to pass: microsoft/hcsshim#1465

Correct, we've found that containrd v1.6.5 and v1.6.6 have issues reporting stats for host-process containers.
I manually validated these tests by setting up a cluster with containerd v1.6.4 on the Windows nodes.
We can keep this PR open until this issue gets patched.

@marosset marosset added this to In Review (v1.25) in SIG-Windows Jul 28, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 2, 2022
@marosset
Copy link
Contributor Author

marosset commented Sep 7, 2022

/milestone v1.26

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 7, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 7, 2022
@marosset
Copy link
Contributor Author

marosset commented Sep 7, 2022

/assign @dcantah
/hold
for to confirm test ran and passed in pull-kubernetes-e2e-capz-windows-containerd

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2022
@marosset
Copy link
Contributor Author

/retest

@marosset
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-containerd

@marosset marosset mentioned this pull request Sep 15, 2022
Open
@marosset
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-containerd

@marosset
Copy link
Contributor Author

The new test passed in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/111332/pull-kubernetes-e2e-capz-windows-containerd/1570474265726160896

/hold cancel
/assign @dcantah @jsturtevant

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2022
@marosset
Copy link
Contributor Author

/remove-sig testing

@k8s-ci-robot k8s-ci-robot removed the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Sep 20, 2022
@marosset marosset removed this from In Review (v1.25) in SIG-Windows Sep 21, 2022
@marosset
Copy link
Contributor Author

@jsturtevant - PTAL

@marosset marosset mentioned this pull request Oct 17, 2022
Closed
35 tasks
@jsturtevant
Copy link
Contributor

the new test passed:

    {"msg":"PASSED [sig-windows] [Feature:WindowsHostProcessContainers] [MinimumKubeletVersion:1.22] HostProcess containers container stats validation","completed":7,"skipped":190,"failed":0}

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2022
@pacoxu
Copy link
Member

pacoxu commented Oct 21, 2022

/hold

test/e2e/windows/host_process.go:637:5: f.PodClient undefined (type *framework.Framework has no field or method PodClient)

You need to fix the ci and feel free to cancel the hold.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2022
pacoxu
pacoxu reviewed Oct 21, 2022
View reviewed changes
test/e2e/windows/host_process.go Outdated
},
}

f.PodClient().Create(pod)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
f.PodClient().Create(pod)
e2epod.NewPodClient(f).Create(pod)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#112043 did some code refactoring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll rebase and clean this up.
Thanks!

@marosset
Add e2e to validate stats for Windows hostprocess containers
da0b66b 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022
@marosset
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 21, 2022
@marosset
Copy link
Contributor Author

/test pull-kubernetes-e2e-kind-ipv6

@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@marosset: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-e2e-capz-windows-containerd da0b66b link false /test pull-kubernetes-e2e-capz-windows-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022
@marosset
Copy link
Contributor Author

/test pull-kubernetes-e2e-capz-windows-containerd
infra flake

@k8s-ci-robot k8s-ci-robot merged commit 0a97662 into kubernetes:master Oct 21, 2022
@marosset marosset deleted the hpc-stats-e2e branch October 21, 2022 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacoxu pacoxu pacoxu left review comments

@chewong chewong Awaiting requested review from chewong

@jayunit100 jayunit100 Awaiting requested review from jayunit100

Assignees

@jsturtevant jsturtevant

@dcantah dcantah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
[sig-release] Bug Triage
Archived in project
[sig-windows] PR tracking
Status: Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@marosset @k8s-ci-robot @jsturtevant @pacoxu @dcantah