Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add metrics for health checks (for later use in apiserver) #111771

Merged
merged 3 commits into from Aug 24, 2022
Merged

add metrics for health checks (for later use in apiserver) #111771

merged 3 commits into from Aug 24, 2022

Conversation

logicalhan
Copy link
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Currently, our health check endpoints only output health information via livez, readyz and healthz. Generally you need to parse the return code to know if the component is healthy. We should also just record this data as a metric, so that we can parse it directly through a monitoring pipeline.

/sig instrumentation

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Aug 9, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2022
@jingyih
Copy link
Contributor

jingyih commented Aug 10, 2022

/cc

@logicalhan
Copy link
Member Author

/retest

@dgrisonnet
Copy link
Member

/triage accepted
/assign @dashpole @dgrisonnet

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 11, 2022
@logicalhan
add metrics for health checks (for later use in apiserver)
895c80b 
Change-Id: I0dff11cc298c4960ae6620004a071ef6a62ddc9a
@logicalhan
address comments
822c52c 
Change-Id: I9c9854b8bb3221e4791c70f566361bd0421061c1
@logicalhan
add counter metric for dashpole
6c451da 
Change-Id: I4a235c0d8b936da960cf5ce25cdd992e94130391
@dashpole
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2022
@dgrisonnet
Copy link
Member

Setting release notes to none since this PR just adds a new metrics Interface that is not yet wired anywhere in the code.

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 23, 2022
@dgrisonnet
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit 6e14428 into kubernetes:master Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Aug 24, 2022
@logicalhan logicalhan mentioned this pull request Sep 30, 2022
Closed
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole left review comments

@pohly pohly Awaiting requested review from pohly

@serathius serathius Awaiting requested review from serathius

@jingyih jingyih Awaiting requested review from jingyih

Assignees

@dashpole dashpole

@dgrisonnet dgrisonnet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@logicalhan @k8s-ci-robot @jingyih @dgrisonnet @dashpole