Refactor schedulingCycle and bindingCycle in scheduler #112025

kerthcet · 2022-08-25T05:54:31Z

What type of PR is this?

/kind cleanup
/sig scheduling

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot · 2022-08-25T05:54:32Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

k8s-ci-robot · 2022-08-25T05:54:38Z

@kerthcet: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kerthcet · 2022-09-14T09:35:46Z

/kind feature

pkg/scheduler/schedule_one.go

kerthcet · 2022-09-15T05:37:51Z

/retest

pkg/scheduler/schedule_one.go

kerthcet · 2022-09-15T06:48:47Z

Flaky test #112465

kerthcet · 2022-09-15T07:16:10Z

This is ready to review. cc @ahg-g @alculquicondor @Huang-Wei

kerthcet · 2022-09-15T13:03:46Z

The flaky test is fixed.
/retest

kerthcet · 2022-10-18T06:52:55Z

Sorry about the squashed commit for solving code conflicts.

pkg/scheduler/schedule_one.go

alculquicondor · 2022-10-19T18:43:14Z

pkg/scheduler/schedule_one.go

-		}
-		sched.FailureHandler(ctx, fwk, assumedPodInfo, sts.AsError(), v1.PodReasonSchedulerError, clearNominatedNode)
-		return ScheduleResult{}, nil
+		return ScheduleResult{nominatingInfo: clearNominatedNode, reason: v1.PodReasonSchedulerError, unreserve: true},


There is only 2 instances where we call Unreserve and Forget during scheduling cycle. Here and after Permit.

It sounds pretty clean to me to just keep the calls here.

bindingCycle handles it differently, but that's not relevant here. In other words, I think we can keep handleBindingCycleError

alculquicondor

/lgtm
/hold
for nit

alculquicondor · 2022-10-20T15:50:13Z

pkg/scheduler/schedule_one.go

+	podsToActivate *framework.PodsToActivate) (
+	ScheduleResult, *framework.QueuedPodInfo, error) {


Suggested change

podsToActivate *framework.PodsToActivate) (

ScheduleResult, *framework.QueuedPodInfo, error) {

podsToActivate *framework.PodsToActivate,

) (ScheduleResult, *framework.QueuedPodInfo, error) {

maybe this is a bit more readable? But up to you

updated and squashed again.

alculquicondor · 2022-10-20T16:06:02Z

pkg/scheduler/schedule_one.go

+		reason = v1.PodReasonUnschedulable
+	}
+
+	sched.FailureHandler(ctx, fwk, podInfo, status.AsError(), reason, clearNominatedNode, start)


Food for thought:

kind of weird that we have to pass an error and a reason.

Perhaps we should be passing a status (although I know it's a bit more tricky for scheduling cycle), or the error should contain information about whether it's unschedulable or not (by implementing Is)

But this can be left for follow up, if you have extra time.

It's something we can optimize later. I'll follow this when I have time.

alculquicondor · 2022-10-20T16:06:52Z

/approve

k8s-ci-robot · 2022-10-20T16:07:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/scheduler/OWNERS~~ [alculquicondor]
~~test/integration/scheduler/OWNERS~~ [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: kerthcet <kerthcet@gmail.com>

kerthcet · 2022-10-21T06:52:03Z

/retest

alculquicondor · 2022-10-21T14:19:26Z

/hold cancel
/lgtm

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 25, 2022

k8s-ci-robot requested review from chendave and denkensk August 25, 2022 05:56

kerthcet mentioned this pull request Aug 29, 2022

Unify the status handle in bindingCycle #112103

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 31, 2022

k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 14, 2022

kerthcet force-pushed the refactor/handle-scheduling-failure branch from 6f4af4d to 1e3d18d Compare September 15, 2022 03:18

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 15, 2022

kerthcet force-pushed the refactor/handle-scheduling-failure branch from 1e3d18d to c7cda01 Compare September 15, 2022 03:34

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2022

kerthcet commented Sep 15, 2022

View reviewed changes

pkg/scheduler/schedule_one.go Show resolved Hide resolved

kerthcet marked this pull request as ready for review September 15, 2022 03:39

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 15, 2022

k8s-ci-robot requested a review from sanposhiho September 15, 2022 03:39

kerthcet commented Sep 15, 2022

View reviewed changes

pkg/scheduler/schedule_one.go Show resolved Hide resolved

pkg/scheduler/schedule_one.go Outdated Show resolved Hide resolved

pkg/scheduler/schedule_one.go Show resolved Hide resolved

kerthcet mentioned this pull request Oct 17, 2022

Fix metrics time durations in schedulerCycle and bindingCycle #113113

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2022

kerthcet force-pushed the refactor/handle-scheduling-failure branch from f3c2ee4 to d52d36e Compare October 18, 2022 06:52

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2022

kerthcet force-pushed the refactor/handle-scheduling-failure branch from d52d36e to b4b459d Compare October 18, 2022 07:30

k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 18, 2022

kerthcet force-pushed the refactor/handle-scheduling-failure branch from b4b459d to 78cfdc3 Compare October 18, 2022 08:45

alculquicondor reviewed Oct 19, 2022

View reviewed changes

alculquicondor reviewed Oct 20, 2022

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2022

k8s-ci-robot assigned alculquicondor Oct 20, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2022

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022

Refactor schedulingCycle and bindingCycle in scheduler

f7f8578

Signed-off-by: kerthcet <kerthcet@gmail.com>

kerthcet force-pushed the refactor/handle-scheduling-failure branch from a076be2 to f7f8578 Compare October 21, 2022 05:53

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2022

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 21, 2022

k8s-ci-robot merged commit 18b8151 into kubernetes:master Oct 21, 2022

k8s-ci-robot added this to the v1.26 milestone Oct 21, 2022

kerthcet deleted the refactor/handle-scheduling-failure branch October 21, 2022 15:32

kerthcet mentioned this pull request Nov 23, 2022

Dedup the code in scheduler.go#scheduleOne() #103853

Closed

kerthcet mentioned this pull request Dec 28, 2022

Add new testcases to integration test TestBindPlugin #114717

Merged

kerthcet mentioned this pull request May 27, 2023

Add kerthcet and sanposhiho as SIG scheduling approvers #118294

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor schedulingCycle and bindingCycle in scheduler #112025

Refactor schedulingCycle and bindingCycle in scheduler #112025

kerthcet commented Aug 25, 2022

k8s-ci-robot commented Aug 25, 2022

k8s-ci-robot commented Aug 25, 2022

kerthcet commented Sep 14, 2022

kerthcet commented Sep 15, 2022

kerthcet commented Sep 15, 2022

kerthcet commented Sep 15, 2022

kerthcet commented Sep 15, 2022

kerthcet commented Oct 18, 2022

alculquicondor Oct 19, 2022

alculquicondor left a comment

alculquicondor Oct 20, 2022

kerthcet Oct 21, 2022

alculquicondor Oct 20, 2022

kerthcet Oct 21, 2022

alculquicondor commented Oct 20, 2022

k8s-ci-robot commented Oct 20, 2022

kerthcet commented Oct 21, 2022

alculquicondor commented Oct 21, 2022

		podsToActivate *framework.PodsToActivate) (
		ScheduleResult, *framework.QueuedPodInfo, error) {

Refactor schedulingCycle and bindingCycle in scheduler #112025

Refactor schedulingCycle and bindingCycle in scheduler #112025

Conversation

kerthcet commented Aug 25, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

k8s-ci-robot commented Aug 25, 2022

k8s-ci-robot commented Aug 25, 2022

kerthcet commented Sep 14, 2022

kerthcet commented Sep 15, 2022

kerthcet commented Sep 15, 2022

kerthcet commented Sep 15, 2022

kerthcet commented Sep 15, 2022

kerthcet commented Oct 18, 2022

alculquicondor Oct 19, 2022

Choose a reason for hiding this comment

alculquicondor left a comment

Choose a reason for hiding this comment

alculquicondor Oct 20, 2022

Choose a reason for hiding this comment

kerthcet Oct 21, 2022

Choose a reason for hiding this comment

alculquicondor Oct 20, 2022

Choose a reason for hiding this comment

kerthcet Oct 21, 2022

Choose a reason for hiding this comment

alculquicondor commented Oct 20, 2022

k8s-ci-robot commented Oct 20, 2022

kerthcet commented Oct 21, 2022

alculquicondor commented Oct 21, 2022