Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kerthcet and sanposhiho as SIG scheduling approvers #118294

Merged
merged 1 commit into from May 30, 2023

Conversation

alculquicondor
Copy link
Member

What type of PR is this?

/kind documentation

What this PR does / why we need it:

/sig scheduling
Add @kerthcet and @sanposhiho as approvers for SIG Scheduling.

They have both been long standing contributors to kube-scheduler.

They have grown to produce high quality code and KEPs and provide meaningful reviews. They are also leading newer contributors to do bugfixes and refactoring.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

I propose that they stay as reviewers for a while. Once we grow the reviewers team, I hope Kensei and Kant can dedicate to their approver role.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 26, 2023
@alculquicondor
Copy link
Member Author

/hold
for @ahg-g and @Huang-Wei

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 26, 2023
@Huang-Wei
Copy link
Member

+100.

@kerthcet and @sanposhiho has been served in sig-scheduling for a while. They have demonstrated comprehensive understanding in the whole scheduler codebase, and led design and impl. of various KEPs and impactful PR and issue fixes. Super glad to have them in this sig, and hope they can keep the momentum!

@kerthcet and @sanposhiho, could you compile a review/pr/kep list (statistically) and comment below? You can refer to some other maintainer's proposal PR or https://github.com/kubernetes/community/blob/master/community-membership.md#approver.

@sanposhiho
Copy link
Member

Thanks @alculquicondor for bringing this up. I greatly appreciate the support from everyone so far.
I'm really honored to be listed there. I'd like to do my best to contribute even more here in the future with this chance.

could you compile a review/pr/kep list (statistically) and comment below?

Sure.

@kerthcet
Copy link
Member

kerthcet commented May 27, 2023

Thanks all for your kindness and guidances, sig scheduling is such a cohesive community, so glad to be part of it. I'll devote myself to help the community become better, whatever the quality of codebase, helping new contributors, introducing exciting features, anything benefit to the healthy of the community.

And I will be careful with critical changes and make sure another approver will be involved in.

Here're some contributions I made to the specific sig-scheduling community following the approver requirements:

I also help to maintain two sub-projects kueue and kube-scheduler-wasm-extension the same time.

Thanks again for all your support.

@ahg-g
Copy link
Member

ahg-g commented May 29, 2023

+1; Thanks @kerthcet and @sanposhiho for your contributions and commitment to the project.

@alculquicondor
Copy link
Member Author

/hold cancel
/assign @dims

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2023
@dims
Copy link
Member

dims commented May 29, 2023

@Huang-Wei @ahg-g @alculquicondor need some approve/lgtm(s) from you all

@alculquicondor
Copy link
Member Author

/approve

1 similar comment
@dims
Copy link
Member

dims commented May 30, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@alculquicondor
Copy link
Member Author

/hold cancel
/lgtm

@k8s-ci-robot
Copy link
Contributor

@alculquicondor: you cannot LGTM your own PR.

In response to this:

/hold cancel
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Huang-Wei
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 01db4c73187e17cb06c255f0c80d7092cdc11cc5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dims, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 0751fee into kubernetes:master May 30, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants