New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kerthcet and sanposhiho as SIG scheduling approvers #118294
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
+100. @kerthcet and @sanposhiho has been served in sig-scheduling for a while. They have demonstrated comprehensive understanding in the whole scheduler codebase, and led design and impl. of various KEPs and impactful PR and issue fixes. Super glad to have them in this sig, and hope they can keep the momentum! @kerthcet and @sanposhiho, could you compile a review/pr/kep list (statistically) and comment below? You can refer to some other maintainer's proposal PR or https://github.com/kubernetes/community/blob/master/community-membership.md#approver. |
Thanks @alculquicondor for bringing this up. I greatly appreciate the support from everyone so far.
Sure.
|
Thanks all for your kindness and guidances, sig scheduling is such a cohesive community, so glad to be part of it. I'll devote myself to help the community become better, whatever the quality of codebase, helping new contributors, introducing exciting features, anything benefit to the healthy of the community. And I will be careful with critical changes and make sure another approver will be involved in. Here're some contributions I made to the specific sig-scheduling community following the approver requirements:
I also help to maintain two sub-projects kueue and kube-scheduler-wasm-extension the same time. Thanks again for all your support. |
+1; Thanks @kerthcet and @sanposhiho for your contributions and commitment to the project. |
/hold cancel |
@Huang-Wei @ahg-g @alculquicondor need some approve/lgtm(s) from you all |
/approve |
1 similar comment
/approve |
/hold cancel |
@alculquicondor: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: 01db4c73187e17cb06c255f0c80d7092cdc11cc5
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, dims, Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
/sig scheduling
Add @kerthcet and @sanposhiho as approvers for SIG Scheduling.
They have both been long standing contributors to kube-scheduler.
They have grown to produce high quality code and KEPs and provide meaningful reviews. They are also leading newer contributors to do bugfixes and refactoring.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I propose that they stay as reviewers for a while. Once we grow the reviewers team, I hope Kensei and Kant can dedicate to their approver role.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: