Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize: file /cpuset slice make cap #112270

Merged
merged 1 commit into from Sep 30, 2022
Merged

Optimize: file /cpuset slice make cap #112270

merged 1 commit into from Sep 30, 2022

Conversation

demoManito
Copy link
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I think slice should initialize cap, which is a good style
reference code specification: https://github.com/uber-go/guide/blob/master/style.md#specifying-slice-capacity

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 7, 2022
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. labels Sep 7, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @demoManito. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 7, 2022
@demoManito
Copy link
Contributor Author

/assign @derekwaynecarr

@pacoxu pacoxu added this to Triage in SIG Node PR Triage Sep 7, 2022
@yxxhero
Copy link
Member

yxxhero commented Sep 8, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2022
@demoManito
Copy link
Contributor Author

/test pull-kubernetes-unit

yxxhero
yxxhero reviewed Sep 12, 2022
View reviewed changes
pkg/kubelet/cm/cpuset/cpuset.go Outdated
var result []int64
if s.IsEmpty() {
return nil
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this judgment necessary? When the for iteration is empty, can it not be returned correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to keep the logic consistent with the previous one. Uninitialized slice can be returned

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 12, 2022
@pacoxu
Copy link
Member

pacoxu commented Sep 21, 2022

/label tide/merge-method-squash
Would you squash commits?

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 21, 2022
@pacoxu
Copy link
Member

pacoxu commented Sep 21, 2022

/priority backlog
/triage accepted

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Sep 21, 2022
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 21, 2022
@demoManito
Copy link
Contributor Author

/label tide/merge-method-squash Would you squash commits?

commits squashed

@pacoxu pacoxu moved this from Triage to Needs Reviewer in SIG Node PR Triage Sep 21, 2022
@haircommander
Copy link
Contributor

haircommander commented Sep 30, 2022 •
edited

/lgtm

good idea!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2022
@haircommander haircommander moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: demoManito, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Sep 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 759e043 into kubernetes:master Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 30, 2022
danielye11 pushed a commit to danielye11/kubernetes that referenced this pull request Oct 10, 2022
@demoManito @danielye11
Optimize: file /cpuset slice make cap (kubernetes#112270)
823539a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxxhero yxxhero yxxhero left review comments

@mrunalp mrunalp mrunalp approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@derekwaynecarr derekwaynecarr

@haircommander haircommander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@demoManito @k8s-ci-robot @yxxhero @pacoxu @haircommander @mrunalp @derekwaynecarr