New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use generic slis as entrypoint for healthcheck metrics #112740
use generic slis as entrypoint for healthcheck metrics #112740
Conversation
@logicalhan: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…venience functions for setting stuff up Change-Id: I19a53bf71272021566f50ab86d0069e2669e547e
1af3c9f
to
63f98e0
Compare
/lgtm |
/hold cancel (got another PR blocked behind this one) |
@logicalhan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
...and expose convenience functions for setting stuff up
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
We need some convenience functions for wiring up component health SLI metrics. This accomplishes that.
Special notes for your reviewer:
Does this PR introduce a user-facing change?