New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize hostname in network proxy test #112763
Sanitize hostname in network proxy test #112763
Conversation
Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
@akankshakumari393: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @akankshakumari393. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold I don't have clear from the issue if this is a problem of the kubeconfig used , or if we should sanitize the host field, but removing the additional slash will make fail setups that have a Host field without a trailing slash Let's comment on the issue first, please |
ok, I see, so the problem here is that we can have: Host = http://localhost:6443 it seems that we should consider this, my suggestion is to always trim the last slash https://github.com/kubernetes/kubernetes/pull/112763/files#r982089562 https://go.dev/play/p/tA97Z4bijRc /hold cancel |
/kind bug |
/label tide/merge-method-squash Thanks |
/test pull-kubernetes-integration unrelated failure |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akankshakumari393, aojea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update Url string to have only one slash Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com> * Trim / from Right in hostname Signed-off-by: Akanksha Kumari <akankshakumari393@gmail.com>
Signed-off-by: Akanksha Kumari akankshakumari393@gmail.com
Fixes #112760
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: