Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize hostname in network proxy test #112763

Merged
merged 2 commits into from Sep 29, 2022
Merged

Sanitize hostname in network proxy test #112763

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd9a7fe
Update Url string to have only one slash
akankshakumari393 Sep 28, 2022
39a96e0
Trim / from Right in hostname
akankshakumari393 Sep 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions test/e2e/network/proxy.go
View file
Open in desktop
Expand Up @@ -350,7 +350,7 @@ var _ = common.SIGDescribe("Proxy", func() {
httpVerbs := []string{"DELETE", "GET", "HEAD", "OPTIONS", "PATCH", "POST", "PUT"}
for _, httpVerb := range httpVerbs {

urlString := f.ClientConfig().Host + "/api/v1/namespaces/" + ns + "/pods/agnhost/proxy/some/path/with/" + httpVerb
urlString := f.ClientConfig().Host + "api/v1/namespaces/" + ns + "/pods/agnhost/proxy/some/path/with/" + httpVerb
akankshakumari393 marked this conversation as resolved.
Show resolved Hide resolved
framework.Logf("Starting http.Client for %s", urlString)

pollErr := wait.PollImmediate(requestRetryPeriod, requestRetryTimeout, validateProxyVerbRequest(client, urlString, httpVerb, msg))
Expand All @@ -361,7 +361,7 @@ var _ = common.SIGDescribe("Proxy", func() {
// For all methods other than HEAD the response body returns 'foo' with the received http method
for _, httpVerb := range httpVerbs {

urlString := f.ClientConfig().Host + "/api/v1/namespaces/" + ns + "/services/test-service/proxy/some/path/with/" + httpVerb
urlString := f.ClientConfig().Host + "api/v1/namespaces/" + ns + "/services/test-service/proxy/some/path/with/" + httpVerb
framework.Logf("Starting http.Client for %s", urlString)

pollErr := wait.PollImmediate(requestRetryPeriod, requestRetryTimeout, validateProxyVerbRequest(client, urlString, httpVerb, msg))
Expand Down Expand Up @@ -444,7 +444,7 @@ var _ = common.SIGDescribe("Proxy", func() {
httpVerbs := []string{"DELETE", "OPTIONS", "PATCH", "POST", "PUT"}
for _, httpVerb := range httpVerbs {

urlString := f.ClientConfig().Host + "/api/v1/namespaces/" + ns + "/pods/agnhost/proxy?method=" + httpVerb
urlString := f.ClientConfig().Host + "api/v1/namespaces/" + ns + "/pods/agnhost/proxy?method=" + httpVerb
framework.Logf("Starting http.Client for %s", urlString)

pollErr := wait.PollImmediate(requestRetryPeriod, requestRetryTimeout, validateProxyVerbRequest(client, urlString, httpVerb, msg))
Expand All @@ -455,7 +455,7 @@ var _ = common.SIGDescribe("Proxy", func() {
// The response body returns 'foo' with the received http method
for _, httpVerb := range httpVerbs {

urlString := f.ClientConfig().Host + "/api/v1/namespaces/" + ns + "/services/" + testSvcName + "/proxy?method=" + httpVerb
urlString := f.ClientConfig().Host + "api/v1/namespaces/" + ns + "/services/" + testSvcName + "/proxy?method=" + httpVerb
framework.Logf("Starting http.Client for %s", urlString)

pollErr := wait.PollImmediate(requestRetryPeriod, requestRetryTimeout, validateProxyVerbRequest(client, urlString, httpVerb, msg))
Expand All @@ -465,10 +465,10 @@ var _ = common.SIGDescribe("Proxy", func() {
// Test that each method returns 301 for both pod and service endpoints
redirectVerbs := []string{"GET", "HEAD"}
for _, redirectVerb := range redirectVerbs {
urlString := f.ClientConfig().Host + "/api/v1/namespaces/" + ns + "/pods/agnhost/proxy?method=" + redirectVerb
urlString := f.ClientConfig().Host + "api/v1/namespaces/" + ns + "/pods/agnhost/proxy?method=" + redirectVerb
validateRedirectRequest(client, redirectVerb, urlString)

urlString = f.ClientConfig().Host + "/api/v1/namespaces/" + ns + "/services/" + testSvcName + "/proxy?method=" + redirectVerb
urlString = f.ClientConfig().Host + "api/v1/namespaces/" + ns + "/services/" + testSvcName + "/proxy?method=" + redirectVerb
validateRedirectRequest(client, redirectVerb, urlString)
}
})
Expand Down