Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote ExpandedDNSConfig feature to beta stage #112824

Merged

Conversation

gjkim42
Copy link
Member

@gjkim42 gjkim42 commented Oct 3, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

This adds an e2e test for ExpandedDNSConfig and promotes KEP 2595 (Expanded DNS Configuration) to the beta stage.

ref: kubernetes/enhancements#2884

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

The ExpandedDNSConfig feature has graduated to beta and is enabled by default. Note that this feature requires container runtime support.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-network/2595-expanded-dns-config

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 3, 2022
@k8s-ci-robot
Copy link
Contributor

@gjkim42: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 3, 2022
@gjkim42 gjkim42 changed the title Promote ExpandedDNSConfig feature to beta stage WIP: Promote ExpandedDNSConfig feature to beta stage Oct 3, 2022
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 3, 2022
@gjkim42 gjkim42 force-pushed the promote-expandeddnsconfig-to-beta branch from 0360ad5 to 5fcdde0 Compare October 3, 2022 09:21
@gjkim42
Copy link
Member Author

gjkim42 commented Oct 3, 2022

/retest

test/e2e/network/dns.go Outdated Show resolved Hide resolved
@sftim
Copy link
Contributor

sftim commented Oct 10, 2022

I wouldn't list container runtime support in the release note: we try not to pick favorites, and I'd rather not try to produce a definitive list of container runtimes that include the necessary support.

If we do add a definitive list, we need to make sure that it remains in alphabetical order.

We don't have project guidance on 3rd party software mentions in release notes, but https://github.com/cncf/foundation/blob/main/website-guidelines.md is along similar lines.

It's OK to publish a blog article for the release where this graduates to beta, and mention compatible runtime examples in that blog article.

  • blog articles are authors' opinions, modulated by project-wide theme and style constraints
  • if you've made, or someone else has made, a reasonable effort to write a balanced blog article, we don't mind if you omitted some obscure runtime that is also compatible, and it's easier to retrospectively add a note to such an article if you ever want to.

This adds an e2e test for the feature and promotes ExpandedDNSConfig
feature to the beta stage.
@gjkim42 gjkim42 force-pushed the promote-expandeddnsconfig-to-beta branch from 1098ff6 to add4652 Compare October 11, 2022 12:00
@aojea
Copy link
Member

aojea commented Oct 11, 2022

@gjkim42 did you forget to remove the WIP from the title or is still something missing?

/lgtm

/assign @thockin
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2022
@gjkim42 gjkim42 changed the title WIP: Promote ExpandedDNSConfig feature to beta stage Promote ExpandedDNSConfig feature to beta stage Oct 11, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 11, 2022
@gjkim42
Copy link
Member Author

gjkim42 commented Oct 11, 2022

I wouldn't list container runtime support in the release note: we try not to pick favorites, and I'd rather not try to produce a definitive list of container runtimes that include the necessary support.

removed the container runtime list from the release note.

And removed WIP.

Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjkim42, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0ef0fa0 into kubernetes:master Oct 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 14, 2022
@gjkim42 gjkim42 deleted the promote-expandeddnsconfig-to-beta branch October 14, 2022 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants