Resolution of preemption_victims metric is limiting

[alculquicondor]

What would you like to be added?

Have better resolution of the metric. The range is probably good (0 to 50), but the resolution is not very useful. Maybe it should be an exponential scale instead of linear

kubernetes/pkg/scheduler/metrics/metrics.go

Line 81 in e11e226

Buckets: metrics.LinearBuckets(5, 5, 10),

Why is this needed?

We should have more visibility around average number of preemptions. It's not possible to see if pods require less than 5 preemptions to inform how expensive preemption is for a certain QPS.

[alculquicondor]

/sig scheduling
/sig instrumentation

@logicalhan is the proposal backwards compatible? The guide is not very clear about changing the buckets, but I seem to remember it's ok to change them
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/metric-stability.md#stable

[logicalhan]

/sig scheduling /sig instrumentation

@logicalhan is the proposal backwards compatible? The guide is not very clear about changing the buckets, but I seem to remember it's ok to change them https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/metric-stability.md#stable

Changing buckets is fine actually.

[lengrongfu]

Can I work for this issue？If there is a better option, feel free to unassign. @alculquicondor

[lengrongfu]

/assign

[pacoxu]

/triage accepted

[lengrongfu]

/close

[k8s-ci-robot]

@lengrongfu: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pacoxu]

/close

If you set Fixes #112912 correctly, this issue will be closed automatically by GitHub. There is an extra # in #112939 (comment).

[k8s-ci-robot]

@pacoxu: Closing this issue.

In response to this:

/close

If you set Fixes #112912 correctly, this issue will be closed automatically by GitHub. There is an extra # in #112939 (comment).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.