Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Read, Replace ReplicationController scale endpoints Conformance - +2 Endpoints #113059

Merged
merged 1 commit into from Oct 14, 2022
Merged

Promote Read, Replace ReplicationController scale endpoints Conformance - +2 Endpoints #113059

merged 1 commit into from Oct 14, 2022

Conversation

Riaankl
Copy link
Contributor

@Riaankl Riaankl commented Oct 13, 2022

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR adds a test to test the following untested endpoints:

  • readCoreV1NamespacedReplicationControllerScale
  • replaceCoreV1NamespacedReplicationControllerScale

Which issue(s) this PR fixes:
Fixes #112585

Testgrid Link:
testgrid-link

Special notes for your reviewer:
Adds +2 endpoint test coverage (good for conformance)

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig testing
/sig architecture
/area conformance

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/conformance Issues or PRs related to kubernetes conformance tests needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels Oct 13, 2022
@Riaankl
Copy link
Contributor Author

Riaankl commented Oct 13, 2022

/assign @dims @smarterclayton @johnbelamaric

@Riaankl
Copy link
Contributor Author

Riaankl commented Oct 13, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 13, 2022
@dims
Copy link
Member

dims commented Oct 13, 2022

/approve
/lgtm
/meow

@k8s-ci-robot
Copy link
Contributor

@dims: cat image

In response to this:

/approve
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, Riaankl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@heyste
Copy link
Member

heyste commented Oct 14, 2022

/test pull-kubernetes-e2e-gce-100-performance

There are no nodes that your pod can schedule to - check your requests, tolerations, and node selectors (0/91 nodes are available: 10 Insufficient memory, 91 Insufficient cpu.)

@k8s-ci-robot k8s-ci-robot merged commit be5ed7b into kubernetes:master Oct 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 14, 2022
@Riaankl Riaankl mentioned this pull request Oct 14, 2022
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@mortent mortent Awaiting requested review from mortent

Assignees

@dims dims

@smarterclayton smarterclayton

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

Write e2e test for Read, Replace ReplicationController scale endpoints +2 Endpoints
6 participants
@Riaankl @dims @k8s-ci-robot @heyste @smarterclayton @johnbelamaric