Bump log level for health check warning for missing components #113107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/XS
|
/release-note-none |
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
liggitt
reviewed
Oct 17, 2022
dims
force-pushed
the
bump-apiserver-healthz-upper-log-verbosity
branch
from
c8c49fc
to
bc81e6e
Compare
Default api server manifest whose liveness check looks like: "/livez?exclude=etcd&exclude=kms-provider-0&exclude=kms-provider-1" Which causes spurious messages in apiserver logs every 10 mins: ``` W1017 00:03:39.938956 9 healthz.go:256] cannot exclude some health checks, no health checks are installed matching "kms-provider-0","kms-provider-1" ``` Let's not log excessive messages especially at warning level. We should do this at a higher level (6 instead of 4). NOTE: we don't change the message returned to the http request, we keep that as-is (does not change on log level) Also see: https://github.com/aws/eks-distro/blob/v1-19-eks-12/projects/kubernetes/kubernetes/1-19/patches/0016-EKS-PATCH-apiserver-healthz-upper-log-verbosity-for-.patch Signed-off-by: Davanum Srinivas <davanum@gmail.com>
dims
force-pushed
the
bump-apiserver-healthz-upper-log-verbosity
branch
from
bc81e6e
to
20de240
Compare
12 tasks
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default api server manifest whose liveness check looks like: "/livez?exclude=etcd&exclude=kms-provider-0&exclude=kms-provider-1"
Which causes spurious messages in apiserver logs every 10 mins:
Let's not log excessive messages especially at warning level. We should do this at a higher level (6 instead of 4). You can see the problem still exists in a recent run in our CI:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/113087/pull-kubernetes-e2e-gce-ubuntu-containerd/1581785806803046400/artifacts/e2e-e1f6435b05-a7d53-master/kube-apiserver.log
Also see:
https://github.com/aws/eks-distro/blob/v1-19-eks-12/projects/kubernetes/kubernetes/1-19/patches/0016-EKS-PATCH-apiserver-healthz-upper-log-verbosity-for-.patch
Signed-off-by: Davanum Srinivas davanum@gmail.com
Signed-off-by: Gyuho Lee leegyuho@amazon.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: