Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump log level for health check warning for missing components #113107

Commits on Oct 17, 2022

  1. Bump log level for health check warning for missing components

    Default api server manifest whose liveness check looks like:
    "/livez?exclude=etcd&exclude=kms-provider-0&exclude=kms-provider-1"
    
    Which causes spurious messages in apiserver logs every 10 mins:
    ```
    W1017 00:03:39.938956       9 healthz.go:256] cannot exclude some health checks, no health checks are installed matching "kms-provider-0","kms-provider-1"
    ```
    
    Let's not log excessive messages especially at warning level. We should
    do this at a higher level (6 instead of 4).
    
    NOTE: we don't change the message returned to the http request, we keep
    that as-is (does not change on log level)
    
    Also see:
    https://github.com/aws/eks-distro/blob/v1-19-eks-12/projects/kubernetes/kubernetes/1-19/patches/0016-EKS-PATCH-apiserver-healthz-upper-log-verbosity-for-.patch
    
    Signed-off-by: Davanum Srinivas <davanum@gmail.com>
    dims committed Oct 17, 2022
    Copy the full SHA
    20de240 View commit details
    Browse the repository at this point in the history