e2e: improve failure handling

[pohly]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The code was unnecessarily complex (intercepting panics without anyone using that).

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

[k8s-ci-robot]

@pohly: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pohly]

/hold

There is code in

kubernetes/test/e2e/upgrades/upgrade_suite.go

Lines 68 to 96 in 6e31c65

	// FinalizeUpgradeTest fills the necessary information about junit.TestCase.
	func FinalizeUpgradeTest(start time.Time, tc *junit.TestCase) {
	tc.Time = time.Since(start).Seconds()
	r := recover()
	if r == nil {
	return
	}
	switch r := r.(type) {
	case framework.FailurePanic:
	tc.Failures = []*junit.Failure{
	{
	Message: r.Message,
	Type: "Failure",
	Value: fmt.Sprintf("%s\n\n%s", r.Message, r.FullStackTrace),
	},
	}
	case e2eskipper.SkipPanic:
	tc.Skipped = fmt.Sprintf("%s:%d %q", r.Filename, r.Line, r.Message)
	default:
	tc.Errors = []*junit.Error{
	{
	Message: fmt.Sprintf("%v", r),
	Type: "Panic",
	Value: fmt.Sprintf("%v", r),
	},
	}
	}
	}

which does something with these special panics.

I don't think that code works in all cases (for example, when Ginkgo itself discovers a failure, which is possible now, or when when some test doesn't use the skipper helper package). We need to figure out what that upgrade test really needs to do and how to do it reliably.

[pohly]

/hold cancel

I removed that code from upgrade_suite.go because the result wasn't used anywhere.

[pohly]

/retest

[pohly]

/retest

[pohly]

/assign @aojea

Can you perhaps review?

[spiffxp]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/OWNERS [spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment