Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: improve failure handling #113383

Merged
merged 1 commit into from Nov 8, 2022

Commits on Nov 2, 2022

  1. e2e framework: simplify failure and skip handling

    The original intention (adding more information for later analysis)
    is probably obsolete because there is no code which does anything
    with the extended error.
    
    The code in upgrade_suite.go collected it in an in-memory JUnit report, but
    then didn't do anything with that field. The code also wouldn't work for
    failures detected by Ginkgo itself, like the upcoming timeout handling. If the
    upgrade suite needs the information, it probably should get it from Gingko with
    a ReportAfterSuite call instead of depending in some fragile interception
    mechanism.
    pohly committed Nov 2, 2022
    Configuration menu
    Copy the full SHA
    80c554c View commit details
    Browse the repository at this point in the history