cluster: remove KUBE_TEST_IGNORE_CLOUDPROVIDER_TAINT which is no longer needed #113635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/provider/gcp
|
/assign @cheftako |
|
/test pull-e2e-gce-cloud-provider-disabled |
|
/retest |
BenTheElder
reviewed
Nov 5, 2022
There was a problem hiding this comment.
let's also clean up
Line 133 in 1f9e20e
https://cs.k8s.io/?q=TEST_IGNORE_CLOUDPROVIDER_TAINT&i=nope&files=&excludeFiles=&repos=
…er needed Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
andrewsykim
force-pushed
the
remove-ignore-cloud-provider-taint-envvar
branch
from
9c1d8c6
to
ae1e93b
Compare
k8s-ci-robot
removed
the
size/XS
|
Good catch, removed that too! |
k8s-ci-robot
added
the
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @dims |
|
/approve |
k8s-ci-robot
added
the
approved
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, BenTheElder, cheftako, dims The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
this was in the queue when we did the code freeze, letting this in. /milestone v1.26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Sy Kim andrewsy@google.com
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
The only prow job using this env var was recently updated to not set this env var anymore (kubernetes/test-infra#27875), so we can delete it.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: