Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: remove KUBE_TEST_IGNORE_CLOUDPROVIDER_TAINT which is no longer needed #113635

Merged
merged 2 commits into from Nov 9, 2022
Merged

cluster: remove KUBE_TEST_IGNORE_CLOUDPROVIDER_TAINT which is no longer needed #113635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
545835e
cluster: remove KUBE_TEST_IGNORE_CLOUDPROVIDER_TAINT which is no long…
andrewsykim Nov 4, 2022
ae1e93b
remove TEST_IGNORE_CLOUDPROVIDER_TAINT from hack/ginkgo-e2e.sh
andrewsykim Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions cluster/gce/config-test.sh
View file
Open in desktop
Expand Up @@ -160,9 +160,6 @@ fi
# shellcheck disable=SC2034 # Variables sourced in other scripts.
FEATURE_GATES=${KUBE_FEATURE_GATES:-}

#Optional: disable the cloud provider no schedule taint for testing.
TEST_IGNORE_CLOUDPROVIDER_TAINT=${KUBE_TEST_IGNORE_CLOUDPROVIDER_TAINT:-}

TERMINATED_POD_GC_THRESHOLD=${TERMINATED_POD_GC_THRESHOLD:-100}

# Extra docker options for nodes.
Expand Down Expand Up @@ -298,8 +295,6 @@ export LOGGING_DESTINATION=${KUBE_LOGGING_DESTINATION:-gcp} # options: gcp
export ENABLE_CLUSTER_LOGGING=${KUBE_ENABLE_CLUSTER_LOGGING:-true}
export ELASTICSEARCH_LOGGING_REPLICAS=1

export TEST_IGNORE_CLOUDPROVIDER_TAINT=${KUBE_TEST_IGNORE_CLOUDPROVIDER_TAINT:-false}

# Optional: Don't require https for registries in our local RFC1918 network
if [[ ${KUBE_ENABLE_INSECURE_REGISTRY:-false} = 'true' ]]; then
EXTRA_DOCKER_OPTS="${EXTRA_DOCKER_OPTS} --insecure-registry 10.0.0.0/8"
Expand Down
5 changes: 0 additions & 5 deletions hack/ginkgo-e2e.sh
View file
Open in desktop
Expand Up @@ -130,11 +130,6 @@ if [[ "${KUBERNETES_PROVIDER}" == "azure" ]]; then
fi
fi

if [[ "${TEST_IGNORE_CLOUDPROVIDER_TAINT:-}" == true ]]; then
echo "Found test ignore cloude provider taint, removing NoSchedule taint from all nodes"
"${KUBE_ROOT}/cluster/kubectl.sh" taint nodes --all node.cloudprovider.kubernetes.io/uninitialized:NoSchedule-
fi

# These arguments are understood by both Ginkgo test suite and CLI.
# Some arguments (like --nodes) are only supported when using the CLI.
# Those get set below when choosing the program.
Expand Down