Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: Fix field apiVersion is missing from events reported from taint manager #114095

Merged
merged 2 commits into from
Aug 21, 2023
Merged

scheduler: Fix field apiVersion is missing from events reported from taint manager #114095

merged 2 commits into from
Aug 21, 2023
+85 −8

Conversation

aimuz
Copy link
Contributor

@aimuz aimuz commented Nov 24, 2022 •
edited

Signed-off-by: aimuz mr.imuz@gmail.com

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #114083

Special notes for your reviewer:

Does this PR introduce a user-facing change?

scheduler: Fix field apiVersion is missing from events reported from taint manager

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 24, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.26 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.26.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Wed Nov 23 21:33:10 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 24, 2022
@k8s-ci-robot
Copy link
Contributor

@aimuz: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 24, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 24, 2022
@aimuz
Copy link
Contributor Author

aimuz commented Nov 24, 2022

/kind bug
/sig node
/sig apps

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 24, 2022
@TommyStarK TommyStarK mentioned this pull request Nov 24, 2022
Closed
@bart0sh
Copy link
Contributor

bart0sh commented Dec 19, 2022

/remove-sig node

@k8s-ci-robot k8s-ci-robot removed the sig/node Categorizes an issue or PR as relevant to SIG Node. label Dec 19, 2022
@bart0sh bart0sh moved this from Triage to Done in SIG Node PR Triage Dec 19, 2022
@feloy
Copy link
Member

feloy commented Dec 19, 2022

@aimuz The changes LGTM
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f59f2030ff4ff6b0396487240cff15e6daad223

@aimuz
Copy link
Contributor Author

aimuz commented Dec 20, 2022

/assign @k82cn

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 20, 2023
@aimuz
Copy link
Contributor Author

aimuz commented Mar 21, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 21, 2023
@dims
Copy link
Member

dims commented Jun 15, 2023

@aimuz how about a test to make sure this doesn't get broken again?

@aimuz
scheduler: Fix field apiVersion is missing from events reported from …
975b2c6 
…taint manager

Signed-off-by: aimuz <mr.imuz@gmail.com>
@aimuz
test: TestPodDeletionEvent
396c8a6 
Signed-off-by: aimuz <mr.imuz@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jun 16, 2023
@k8s-ci-robot k8s-ci-robot requested a review from feloy June 16, 2023 02:32
@aimuz
Copy link
Contributor Author

aimuz commented Jun 16, 2023

@dims is a good suggestion, I have added the test

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Jun 16, 2023
@aimuz
Copy link
Contributor Author

aimuz commented Jun 16, 2023

/test pull-kubernetes-integration

@aimuz
Copy link
Contributor Author

aimuz commented Jun 21, 2023

/pin @dims @k82cn @feloy

@aimuz
Copy link
Contributor Author

aimuz commented Jul 6, 2023

/pin @dims @k82cn @feloy

Do you have time to review it?

@aimuz
Copy link
Contributor Author

aimuz commented Aug 21, 2023 •
edited

/assign @liggitt

Please review the code for me, thanks, 🙏

@liggitt
Copy link
Member

liggitt commented Aug 21, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8993a12c95e135f08bd6a905c46b9ea29dc3e4dc

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aimuz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6cbc5df into kubernetes:master Aug 21, 2023
12 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@k82cn k82cn Awaiting requested review from k82cn

@feloy feloy Awaiting requested review from feloy

Assignees

@liggitt liggitt

@feloy feloy

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Node PR Triage
Archived in project
SIG Node PR Triage
Done
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

Field apiVersion is missing from events reported from taint manager
8 participants
@aimuz @k8s-ci-robot @bart0sh @feloy @k8s-triage-robot @dims @liggitt @k82cn