New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated cherry pick of #111772: kubelet: make the image pull time more accurate in event #114271
Automated cherry pick of #111772: kubelet: make the image pull time more accurate in event #114271
Conversation
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
Signed-off-by: Paco Xu <paco.xu@daocloud.io>
@pacoxu: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @bobbypage @klueska |
/kind bug |
/lgtm |
/lgtm Thanks for backporting this, I think this will reduce confusion. One small nit, perhaps it's worth to add release note. /assign @mrunalp |
/approve |
/cc kubernetes/release-managers |
We're now past the cherry-pick deadline, so we'll not be able to include this cherry-pick in the December patch releases. We'll make sure to review this PR as soon as the December patch releases are out. |
From @bobbypage:
@pacoxu I agree with this -- can you please add a release note for this change? Also, I only see cherry-picks for 1.25 and 1.24. Should we also include this in 1.23? If it is possible to include it, would you mind creating a cherry-pick for 1.23 as well? |
Updated. |
Awesome @pacoxu , waiting for the 1.23 approval to merge the whole set. Thank you! 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For RelEng:
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: klueska, pacoxu, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Cherry pick of #111772 on release-1.25.
#111772: kubelet: make the image pull time more accurate in event
For details on the cherry pick process, see the cherry pick requests page.
#111772 (comment)