Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apiserver: update serialization version priority for flowcontrol API #114492

Merged
merged 1 commit into from
Jan 13, 2023
Merged

apiserver: update serialization version priority for flowcontrol API #114492

merged 1 commit into from
Jan 13, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Dec 14, 2022 •
edited

What type of PR is this?

/kind api-change

What this PR does / why we need it:

apiserver: update serialization version priority for flowcontrol API

According to https://kubernetes.io/docs/reference/using-api/deprecation-policy/:

Rule #4b: The "preferred" API version and the "storage version" for a given group may not advance until after a release has been made that supports both the new version and the previous version

flowcontrol.apiserver.k8s.io/v1beta3 is introduced in v1.26, we should set it as the preferred serialization version in v1.27.

This can be done because downgrades are only supported down to 1.26 and that release supports v1beta3.

Which issue(s) this PR fixes:

Fixes #112512

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 14, 2022
@k8s-ci-robot k8s-ci-robot added area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 14, 2022
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Dec 15, 2022
@SataQiu SataQiu force-pushed the update-prefered-storageversion-20221215 branch from 810160c to 27b0c3d Compare December 15, 2022 06:29
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 15, 2022
@SataQiu SataQiu changed the title apiserver: update serialization version priority for flowcontrol and policy api apiserver: update serialization version priority for flowcontrol API Dec 15, 2022
@SataQiu
Copy link
Member Author

SataQiu commented Dec 15, 2022

/hold
waiting for staging/src/k8s.io/api/testdata version bump.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 15, 2022
@fedebongio
Copy link
Contributor

/assign @deads2k
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 15, 2022
@SataQiu SataQiu force-pushed the update-prefered-storageversion-20221215 branch from 27b0c3d to 950c147 Compare January 13, 2023 14:19
@SataQiu
Copy link
Member Author

SataQiu commented Jan 13, 2023

/hold cancel
/assign @liggitt

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2023
@liggitt
Copy link
Member

liggitt commented Jan 13, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a4a76463dd7de784c35872d665e3b3270d8c3f49

@liggitt liggitt removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit e51fe4a into kubernetes:master Jan 13, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@liggitt liggitt

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

Set v1beta3 as the storage version for flowconrol in 1.27
6 participants
@SataQiu @k8s-triage-robot @fedebongio @liggitt @k8s-ci-robot @deads2k