Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet/nodestatus: Improving test coverage #114558

Merged
merged 1 commit into from Mar 10, 2023
Merged

kubelet/nodestatus: Improving test coverage #114558

merged 1 commit into from Mar 10, 2023

Conversation

TommyStarK
Copy link
Contributor

Signed-off-by: TommyStarK thomasmilox@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

If applied this commit will increase the unit tests code coverage of pkg/kubelet/nodestatus

  • Initial unit tests code coverage

Screenshot 2022-12-17 at 19 34 24

  • After changes

Screenshot 2022-12-17 at 19 33 39

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @TommyStarK. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Dec 17, 2022
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 17, 2022
@TommyStarK
Copy link
Contributor Author

Hello @bobbypage, @endocrimes

I know you are super busy and this PR is far from being a priority. As a very new aspiring contributor I am still trying to tame the beast, I thought that working on small pieces could be a good starting point. Hope you won't mind :)

Remaining at your disposal if you have any remark/feedback.

Best,

@aojea
Copy link
Member

aojea commented Dec 17, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2022
@TommyStarK TommyStarK force-pushed the unit-tests/pkg-kubelet-nodestatus branch 2 times, most recently from 4389738 to 4a42b7e Compare December 18, 2022 20:58
@TommyStarK
kubelet/nodestatus: Improving test coverage
a00221e 
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
@TommyStarK TommyStarK force-pushed the unit-tests/pkg-kubelet-nodestatus branch from 4a42b7e to a00221e Compare December 18, 2022 22:20
@TommyStarK TommyStarK requested review from aojea and removed request for bobbypage and endocrimes December 21, 2022 11:22
@bart0sh
Copy link
Contributor

bart0sh commented Dec 27, 2022

/priority important-longterm
/triage accepted

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 27, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Dec 27, 2022
@bart0sh bart0sh added this to Needs Reviewer in SIG Node PR Triage Dec 27, 2022
@bart0sh
Copy link
Contributor

bart0sh commented Dec 30, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8a173b65de3b0b4585d4bb84359df0dacbd60797

@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Dec 30, 2022
@bart0sh
Copy link
Contributor

bart0sh commented Dec 30, 2022

/assign @derekwaynecarr @mrunalp @dchen1107

@TommyStarK
Copy link
Contributor Author

@SergeyKanzhelev I tried to contact kubelet approvers to move on on those PRs and avoid the lifecycle/stale label

@derekwaynecarr
Copy link
Member

Thank you for the test improving our overall coverage.

/lgtm
/approving

@derekwaynecarr
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, TommyStarK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1b647d5 into kubernetes:master Mar 10, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 10, 2023
@TommyStarK TommyStarK deleted the unit-tests/pkg-kubelet-nodestatus branch March 10, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

Assignees

@mrunalp mrunalp

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@TommyStarK @k8s-ci-robot @aojea @bart0sh @derekwaynecarr @mrunalp @dchen1107