Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet: Replace deprecated pointer function #114785

Merged
merged 1 commit into from Mar 2, 2023
Merged

kubelet: Replace deprecated pointer function #114785

merged 1 commit into from Mar 2, 2023

Conversation

TommyStarK
Copy link
Contributor

@TommyStarK TommyStarK commented Jan 3, 2023 •
edited

Signed-off-by: TommyStarK thomasmilox@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

If applied this commit will replace the deprecated (Int32|Int64|Float64|Bool|String)Ptr function by Int32|Int64|Float64|Bool|String.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @TommyStarK. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 3, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jan 3, 2023

/priority important-longterm
/triage accepted
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 3, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jan 3, 2023

/assign

@bart0sh bart0sh added this to Triage in SIG Node PR Triage Jan 3, 2023
@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Jan 3, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Jan 4, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22f7351f38f60565a78d0a28bb9128063e639709

@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Jan 4, 2023
@TommyStarK TommyStarK force-pushed the kubelet/replace-deprecated-pointer-function branch from c8365ad to eab3a99 Compare January 8, 2023 12:31
@k8s-ci-robot k8s-ci-robot removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 8, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 8, 2023
@TommyStarK
kubelet: Replace deprecated pointer function
1fcc8fb 
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
@TommyStarK TommyStarK force-pushed the kubelet/replace-deprecated-pointer-function branch from eab3a99 to 1fcc8fb Compare January 8, 2023 12:44
@bart0sh
Copy link
Contributor

bart0sh commented Jan 9, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0a88baa1bea1492df42c5799cc392be717ad80b

SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TommyStarK
Copy link
Contributor Author

following instructions from k8s-ci-robot

/assign thockin

@pacoxu
Copy link
Member

pacoxu commented Feb 22, 2023

/assign dchen1107 mrunalp

@thockin
Copy link
Member

thockin commented Mar 2, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SergeyKanzhelev, thockin, TommyStarK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 53f3583 into kubernetes:master Mar 2, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 2, 2023
@TommyStarK TommyStarK deleted the kubelet/replace-deprecated-pointer-function branch March 2, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@pacoxu pacoxu Awaiting requested review from pacoxu

@bart0sh bart0sh Awaiting requested review from bart0sh

Assignees

@thockin thockin

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@TommyStarK @k8s-ci-robot @bart0sh @pacoxu @thockin @SergeyKanzhelev