Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubelet: fix recording when pulling image did finish #114904

Merged
merged 1 commit into from Mar 14, 2023
Merged

kubelet: fix recording when pulling image did finish #114904

merged 1 commit into from Mar 14, 2023

Conversation

TommyStarK
Copy link
Contributor

@TommyStarK TommyStarK commented Jan 8, 2023 •
edited by k8s-ci-robot

Signed-off-by: TommyStarK thomasmilox@gmail.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Kubelet image manager wasn't recording when pulling the image did finish, it is now available for the pod_startup_latency_tracker.

Which issue(s) this PR fixes:

Fixes #114903

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubelet: fix recording issue when pulling image did finish

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 8, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @TommyStarK. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 8, 2023
@TommyStarK TommyStarK force-pushed the kubelet/pod_startup_latency_tracker branch from 435d64e to 7328457 Compare January 8, 2023 16:53
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Jan 8, 2023
@TommyStarK
Copy link
Contributor Author

TommyStarK commented Jan 8, 2023 •
edited

cc @aojea, a first draft to address the issue #114903, any feedback will be greatly appreciated (If you feel the approach is too naive please dont hesitate to tell me if you had something else in mind)

Best,

@TommyStarK TommyStarK force-pushed the kubelet/pod_startup_latency_tracker branch from 7328457 to 6df797c Compare January 8, 2023 17:30
@aojea
Copy link
Member

aojea commented Jan 8, 2023

/ok-to-test

some comments but I think that this is good to cover from regressions,
Thanks

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2023
@TommyStarK TommyStarK force-pushed the kubelet/pod_startup_latency_tracker branch from 6df797c to 0898c6f Compare January 8, 2023 19:36
@TommyStarK TommyStarK requested review from aojea and removed request for dchen1107 and tallclair January 8, 2023 19:50
@TommyStarK TommyStarK force-pushed the kubelet/pod_startup_latency_tracker branch from 0898c6f to 10639a7 Compare January 10, 2023 10:42
@bart0sh bart0sh added this to Triage in SIG Node PR Triage Jan 11, 2023
@TommyStarK
Copy link
Contributor Author

@pacoxu, I took your emoji as a yes and removed recording timestamps when image is present. If there is anything please don't hesitate.

Best,

@TommyStarK
Copy link
Contributor Author

/retest-required

@pacoxu
Copy link
Member

pacoxu commented Feb 23, 2023

Either is OK with me.
/lgtm
The current change is very clear to add the RecordImageFinishedPulling back.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ba3fb5ab8aad6345750b64af5114623e6eb8f9f8

@bart0sh bart0sh moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Feb 23, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2023
@TommyStarK
kubelet: fix recording when pulling image did finish
951decd 
Signed-off-by: TommyStarK <thomasmilox@gmail.com>
@TommyStarK TommyStarK force-pushed the kubelet/pod_startup_latency_tracker branch from ed0bd26 to 951decd Compare March 2, 2023 19:22
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023
@k8s-ci-robot k8s-ci-robot requested a review from pacoxu March 2, 2023 19:22
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2023
@TommyStarK
Copy link
Contributor Author

@pacoxu PR has been rebased

SergeyKanzhelev
SergeyKanzhelev approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bcc5430b294763dead11beab7610d48b5d2aa654

@TommyStarK
Copy link
Contributor Author

@SergeyKanzhelev I tried to contact kubelet approvers to move on on those PRs and avoid the lifecycle/stale label

@pacoxu
Copy link
Member

pacoxu commented Mar 8, 2023

/remove-priority important-longterm
/priority important-soon
/assign @kubernetes/sig-node-leads

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 8, 2023
@TommyStarK
Copy link
Contributor Author

TommyStarK commented Mar 10, 2023 •
edited

@derekwaynecarr any feedback from you will be greatly appreciated

@derekwaynecarr
Copy link
Member

thanks for the fix.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, SergeyKanzhelev, TommyStarK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 898143a into kubernetes:master Mar 14, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 14, 2023
@TommyStarK TommyStarK deleted the kubelet/pod_startup_latency_tracker branch March 14, 2023 17:08
@MPV MPV mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruiwen-zhao ruiwen-zhao ruiwen-zhao left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@aojea aojea Awaiting requested review from aojea

@bart0sh bart0sh Awaiting requested review from bart0sh

@mrunalp mrunalp Awaiting requested review from mrunalp

@pacoxu pacoxu Awaiting requested review from pacoxu

Assignees

@mrunalp mrunalp

@pacoxu pacoxu

@SergeyKanzhelev SergeyKanzhelev

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

pod_startup_latency_tracker doesn't track the lastFinishedPulling time
9 participants
@TommyStarK @k8s-ci-robot @aojea @bart0sh @SergeyKanzhelev @pacoxu @derekwaynecarr @ruiwen-zhao @mrunalp