New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.25] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests #115050
[1.25] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests #115050
Conversation
@MadhavJivrajani: This cherry pick PR is for a release branch and has not yet been approved by Release Managers. To merge this cherry pick, it must first be approved ( AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers (This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.) For details on the patch release process and schedule, see the Patch Releases page. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retets |
/retest |
1 similar comment
/retest |
/approve |
/triage accepted |
we'll still hold this until we're closer to updating this release branch to go1.20, but would you mind rebasing this on latest release-1.25 to exercise this with the go-compatibility unit and integration tests? |
Bumping version to include changes that better handle TLS errors. Bump nescessary to prepare for when the version of Go is bumped to 1.20 Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
Modify unwrap error utility to make it work with go1.20 This version of Go introduces a new layer of wrapping via a new error type. The commit accounts for that while being compatible with go1.19 Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
8a7056c
to
fa1445a
Compare
/test pull-kubernetes-dependencies we'll be ready to bump to go1.20 in a couple weeks, so resuming test/prep on this |
/lgtm |
LGTM label has been added. Git tree hash: 6a0a9dc52a9f78724b713f1da21e399b2abad977
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt, MadhavJivrajani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @kubernetes/release-managers |
/hold |
patch releases are out /hold cancel |
/retest |
1 similar comment
/retest |
What type of PR is this?
/kind failing-test
/priority important-soon
What this PR does / why we need it:
Cherry pick of #114766
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @liggitt @dims