Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.26] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests #115051

Merged
merged 4 commits into from
May 23, 2023
Merged

[1.26] Cherry Pick of #114766: [Prepare for go1.20] *: Bump versions and fix tests #115051

merged 4 commits into from
May 23, 2023

Conversation

MadhavJivrajani
Copy link
Contributor

What type of PR is this?

/kind failing-test
/priority important-soon

What this PR does / why we need it:

Cherry pick of #114766

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/assign @liggitt @dims

@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Jan 13, 2023
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

@MadhavJivrajani: This cherry pick PR is for a release branch and has not yet been approved by Release Managers.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved (/lgtm + /approve) by the relevant OWNERS.

AFTER it has been approved by code owners, please leave the following comment on a line by itself, with no leading whitespace: /cc kubernetes/release-managers

(This command will request a cherry pick review from Release Managers and should work for all GitHub users, whether they are members of the Kubernetes GitHub organization or not.)

For details on the patch release process and schedule, see the Patch Releases page.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes labels Jan 13, 2023
@k8s-ci-robot k8s-ci-robot added area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 13, 2023
@dims
Copy link
Member

dims commented Jan 13, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fb3462c2bf41b625a5ff27dd970bcc06605a0d01

@bart0sh bart0sh moved this from Triage to Needs Approver in SIG Node PR Triage Jan 19, 2023
@mrunalp mrunalp moved this from Needs Approver to Done in SIG Node PR Triage Jan 31, 2023
@liggitt
Copy link
Member

liggitt commented Mar 2, 2023

we'll still hold this until we're closer to updating this release branch to go1.20, but would you mind rebasing this on latest release-1.26 to exercise this with the go-compatibility unit and integration tests?

@MadhavJivrajani
Copy link
Contributor Author

MadhavJivrajani commented Mar 10, 2023 •
edited

Missed this comment, let me rebase this and the other cherry picks, thanks

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2023
@liggitt
Copy link
Member

liggitt commented May 3, 2023

/test pull-kubernetes-dependencies
/test pull-kubernetes-integration
/test pull-kubernetes-integration-go-compatibility
/test pull-kubernetes-unit
/test pull-kubernetes-unit-go-compatibility
/hold cancel

we'll be ready to bump to go1.20 in a couple weeks, so resuming test/prep on this

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@Verolop
Copy link

Verolop commented May 3, 2023

/test pull-kubernetes-dependencies

@liggitt
Copy link
Member

liggitt commented May 3, 2023

The failure looks legitimate... @MadhavJivrajani, can you rebase this one and rerun update-vendor.sh?

@MadhavJivrajani
*: Bump version of vmware/govmomi
3ac7014 
Bumping version to include changes that
better handle TLS errors. Bump nescessary
to prepare for when the version of Go is
bumped to 1.20

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani
vsphere: Adapt to govmomi version bumps
40797a1 
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani
vclib: Modify x509.UnknownAuthorityError unwrap check
b73b79d 
Modify unwrap error utility to make it work with go1.20
This version of Go introduces a new layer of wrapping via
a new error type. The commit accounts for that while being
compatible with go1.19

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@MadhavJivrajani
run update-vendor.sh
ef5e78f 
Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@liggitt
Copy link
Member

liggitt commented May 4, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 876a188825d33e536e8f89f888b84afa6930f93b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, MadhavJivrajani

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

liggitt commented May 4, 2023

cc @kubernetes/release-managers
this would be good to get in after the May patch releases are cut

@xmudrii
Copy link
Member

xmudrii commented May 11, 2023

/hold
to avoid accidentally merging those PRs before May patch releases are cut

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2023
@liggitt
Copy link
Member

liggitt commented May 18, 2023

patch releases are out

/hold cancel
/test pull-kubernetes-dependencies
/test pull-kubernetes-integration
/test pull-kubernetes-integration-go-compatibility
/test pull-kubernetes-unit
/test pull-kubernetes-unit-go-compatibility

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2023
@liggitt liggitt mentioned this pull request May 23, 2023
Closed
@jeremyrickard jeremyrickard added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 23, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4dfe380 into kubernetes:release-1.26 May 23, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kubectl cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Auth
Archived in project
SIG Node CI/Test Board
Archive-it
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Archived in project
[sig-architecture] Dependency management
Status: Done
SIG Node PR Triage
Done
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@MadhavJivrajani @k8s-ci-robot @dims @liggitt @cici37 @Verolop @xmudrii @jeremyrickard