Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup dead code in the codebase #115088

Closed
thockin opened this issue Jan 16, 2023 · 7 comments · Fixed by #115168
Closed

Cleanup dead code in the codebase #115088

thockin opened this issue Jan 16, 2023 · 7 comments · Fixed by #115168
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.

Comments

@thockin
Copy link
Member

thockin commented Jan 16, 2023

#111654 started here but it got big (shocking!) and the contributor got busy. There are a lot of potential cleanups in there, though, and I hate wasting work.

I see it as an opportunity for someone to rack up some PRs and net-negative LOCs (the best kind!) - just take over that PR, break it up into a bunch of smaller PRs, and send them our way!

A very eager beaver might automate this, but there's a lot of manually-identified low-hanging fruit, I think.

@thockin thockin added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Jan 16, 2023
@k8s-ci-robot
Copy link
Contributor

@thockin: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 16, 2023
@thockin thockin removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 16, 2023
@HirazawaUi
Copy link
Contributor

very willing to oblige

@HirazawaUi
Copy link
Contributor

/assign

@DaviMatheus
Copy link

/assign

@dereknola
Copy link

dereknola commented Apr 10, 2023

I would like to point out that CRI-Dockerd was in fact using some of the "unused" functions in #115103. Just because K8s is not using the function doesn't mean some other repo/project is not.

@dims
Copy link
Member

dims commented Apr 10, 2023

@dereknola we don't have guarantees about functions/methods etc. CRI-dockerd is welcome to copy the ones that dropped off from there.

@thockin
Copy link
Member Author

thockin commented Apr 10, 2023

To be crystal clear - we do not support or endorse importing k8s.io/kubernetes/... AT ALL. We offer no guarantees of stability there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants