Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove unused code of Resource() and Kind() in kubeadm #116567

Closed
wants to merge 1 commit into from
Closed

cleanup: remove unused code of Resource() and Kind() in kubeadm #116567

wants to merge 1 commit into from

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Mar 14, 2023 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In #115088, kubeadm related are not cleanup yet.

Which issue(s) this PR fixes:

xref #115088

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 14, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Mar 14, 2023

/assign @SataQiu

Fb9027
Fb9027 approved these changes Mar 14, 2023
View reviewed changes
Copy link

@Fb9027 Fb9027 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disconnect still in my email on my Facebook in my Instagram locking me out

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Fb9027, pacoxu
Once this PR has been reviewed and has the lgtm label, please ask for approval from sataqiu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SataQiu
Copy link
Member

SataQiu commented Mar 14, 2023

@pacoxu
I'm not sure, but I have a feeling that we shouldn't change beta API, especially deleting something.
Maybe clean up the unused code in a new API version (v1beta4)?
We can create an issue for v1beta4.

@pacoxu
Copy link
Member Author

pacoxu commented Mar 14, 2023

I'm not sure, but I have a feeling that we shouldn't change the beta API, especially deleting something.

Not sure if there are consumers of these two functions.
/close
this maybe not be a good cleanup. A similar PR is hold for https://github.com/kubernetes/kubernetes/pull/115095/files#r1072811617.

Maybe clean up the unused code in a new API version (v1beta4)?
We can create an issue for v1beta4.

Yes. Probably, we should avoid adding these for v1beta4 later.

@k8s-ci-robot
Copy link
Contributor

@pacoxu: Closed this PR.

In response to this:

I'm not sure, but I have a feeling that we shouldn't change the beta API, especially deleting something.

Not sure if there are consumers of these two functions.
/close
this maybe not be a good cleanup. A similar PR is hold for https://github.com/kubernetes/kubernetes/pull/115095/files#r1072811617.

Maybe clean up the unused code in a new API version (v1beta4)?
We can create an issue for v1beta4.

Yes. Probably, we should avoid adding these for v1beta4 later.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pacoxu pacoxu mentioned this pull request Jun 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fb9027 Fb9027 Fb9027 approved these changes

@neolit123 neolit123 Awaiting requested review from neolit123

@RA489 RA489 Awaiting requested review from RA489

Assignees

@SataQiu SataQiu

Labels
area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pacoxu @k8s-ci-robot @SataQiu @Fb9027