Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move StatefulSetStartOrdinal feature gate to beta #115260

Merged
merged 2 commits into from Mar 10, 2023
Merged

Move StatefulSetStartOrdinal feature gate to beta #115260

merged 2 commits into from Mar 10, 2023

Conversation

pwschuurman
Copy link
Contributor

@pwschuurman pwschuurman commented Jan 23, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR moves the StatefulSetStartOrdinal from alpha -> beta. It also default enables the feature.

Does this PR introduce a user-facing change?

Enable the "StatefulSetStartOrdinal" feature gate in beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 23, 2023
@pwschuurman pwschuurman mentioned this pull request Jan 23, 2023
Closed
12 tasks
@liggitt
Copy link
Member

liggitt commented Feb 22, 2023 •
edited

commented on https://github.com/kubernetes/kubernetes/pull/112744/files#r1114602379, but there's a validation fix needed to always validate the field if non-nil, regardless of feature gate enablement

@pwschuurman pwschuurman force-pushed the kep-3335-statefulset-start-ordinal-beta branch from d59a531 to a68b28a Compare February 24, 2023 00:36
@pwschuurman
Copy link
Contributor Author

commented on https://github.com/kubernetes/kubernetes/pull/112744/files#r1114602379, but there's a validation fix needed to always validate the field if non-nil, regardless of feature gate enablement

Raised #116025. To be fixed in #116027

@pwschuurman pwschuurman marked this pull request as ready for review February 24, 2023 00:46
@pwschuurman pwschuurman changed the title [WIP] Move StatefulSetStartOrdinal feature gate to beta Move StatefulSetStartOrdinal feature gate to beta Feb 24, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2023
@pwschuurman
Copy link
Contributor Author

/cc @soltysh

soltysh
soltysh requested changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to update the api fields

kubernetes/staging/src/k8s.io/api/apps/v1/types.go

Line 263 in d446beb

// enabled, which is alpha.

so they say beta, all of them 😅

@soltysh
Copy link
Contributor

soltysh commented Mar 3, 2023

/triage accepted
/priority backlog
/sig apps

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 3, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 7, 2023
@pwschuurman
Copy link
Contributor Author

You also need to update the api fields

kubernetes/staging/src/k8s.io/api/apps/v1/types.go

Line 263 in d446beb

// enabled, which is alpha.

so they say beta, all of them

Thanks updated all the types.go files, and reflected changes to the autogenerated files.

@pwschuurman
Copy link
Contributor Author

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label Mar 7, 2023
@liggitt liggitt added this to Assigned in API Reviews Mar 7, 2023
soltysh
soltysh approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
from sig-apps pov
tests are blocked by switching this to on by default in #115468

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0ea0e09c14f14c0b8d4d4885087d4ffee7e5cb6

@smarterclayton
Copy link
Contributor

/approve

given sig tag and backport of the validation issue

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, smarterclayton, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8fbfbd9 into kubernetes:master Mar 10, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Mar 10, 2023
@liggitt liggitt moved this from Assigned to API review completed, 1.27 in API Reviews Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@soltysh soltysh

@smarterclayton smarterclayton

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.27
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pwschuurman @k8s-ci-robot @liggitt @soltysh @smarterclayton