New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: Fix fs quota monitoring on volumes #115314
Conversation
Hi @alex-matei. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4fcf78e
to
69f5c25
Compare
d66244b
to
6bc2b34
Compare
/cc |
I tried to fix it at #112624.
|
6bc2b34
to
36738b4
Compare
Hi @pacoxu, I tested the fix and it works, I modified AssignQuota to be idempotent. |
/ok-to-test |
36738b4
to
38458d9
Compare
/retest |
File system quota monitoring setup fails on subsequent invocations, each time quota setup is invoked a new random UID is generated for each pod and compared with the previously stored UID for the folder. Fix it by keeping track of mapping between internal uid generated for a pod and actual external pod uid. Signed-off-by: Alexandru Matei <alexandru.matei@uipath.com>
b011f38
to
b225d6c
Compare
Rebased on top of master to see if it fixes the failing tests. Edit: I looked at the job history and it doesn't seem related, those tests failed continuously since December. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alex-matei, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
LGTM label has been added. Git tree hash: 0fe1ca01e09ff7fa3475a1c3c70221cae3bff01c
|
/retest-required |
@alex-matei: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-e2e-gce |
/test pull-kubernetes-unit |
Should this be cherry-picked to v1.26 and v1.25? |
I think it would be useful. |
What type of PR is this?
Add one of the following kinds:
/kind bug
What this PR does / why we need it:
File system quota monitoring setup fails on subsequent invocations, each time quota setup is invoked a new random UID is generated for each pod and compared with the previously stored UID.
This PR fixes it by keeping track of mapping between internal uid generated for a pod and actual external pod uid.
If there is already a quota project id associated with the folder it uses that instead of returning an error.
If quota is already set on a folder and the quota is the same it does an early exit.
Which issue(s) this PR fixes:
Fixes #114506, #112081, #115309
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: