Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggregated Discovery should not cache on legacy fallback #115559

Closed
Jefftree opened this issue Feb 6, 2023 · 2 comments · Fixed by #115770
Closed

Aggregated Discovery should not cache on legacy fallback #115559

Jefftree opened this issue Feb 6, 2023 · 2 comments · Fixed by #115770
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Jefftree
Copy link
Member

Jefftree commented Feb 6, 2023

What happened?

Aggregated discovery caches when fetching from legacy discovery (https://github.com/kubernetes/kubernetes/blob/1ba14700a5448f0cb54b9f5a79100eea71d05e65/staging/src/k8s.io/kube-aggregator/pkg/apiserver/handler_discovery.go#L295-L297).

This causes apiservices who share the same service key to fetch from the cache and returns an empty document when their group-version differs from the initial apiservice that loaded the cache.

What did you expect to happen?

See above

How can we reproduce it (as minimally and precisely as possible)?

See above

Anything else we need to know?

No response

Kubernetes version

1.26

Cloud provider

local

OS version

# On Linux:
$ cat /etc/os-release
# paste output here
$ uname -a
# paste output here

# On Windows:
C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture
# paste output here

Install tools

Container runtime (CRI) and version (if applicable)

Related plugins (CNI, CSI, ...) and versions (if applicable)

@Jefftree Jefftree added the kind/bug Categorizes issue or PR as related to a bug. label Feb 6, 2023
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 6, 2023
@Jefftree
Copy link
Member Author

Jefftree commented Feb 6, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 6, 2023
@Jefftree
Copy link
Member Author

Jefftree commented Feb 6, 2023

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
3 participants
@Jefftree @k8s-ci-robot and others