Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: topology-mgr: Add metric to measure topology manager admission latency #115590

Merged
merged 3 commits into from Feb 15, 2023
Merged

node: topology-mgr: Add metric to measure topology manager admission latency #115590

merged 3 commits into from Feb 15, 2023

Conversation

swatisehgal
Copy link
Contributor

@swatisehgal swatisehgal commented Feb 7, 2023 •
edited

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add metric to measure topology manager admission latency.

Which issue(s) this PR fixes:

Fixes #693

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Add kubelet Topology Manager metric to measure topology manager admission latency.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: https://github.com/kubernetes/enhancements/pull/3745

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2023
@swatisehgal swatisehgal mentioned this pull request Feb 7, 2023
Closed
11 tasks
@swatisehgal swatisehgal changed the title node: topology-mgr: Add metrics to measure topology manager admission latency. node: topology-mgr: Add metrics to measure topology manager admission latency Feb 7, 2023
@k8s-ci-robot k8s-ci-robot added area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2023
@swatisehgal swatisehgal mentioned this pull request Feb 7, 2023
Merged
@swatisehgal swatisehgal changed the title node: topology-mgr: Add metrics to measure topology manager admission latency node: topology-mgr: Add metric to measure topology manager admission latency Feb 7, 2023
SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

this ^^ will work for the change in test/e2e_node/topology_manager_metrics_test.go

@SergeyKanzhelev
Copy link
Member

/assign @ffromani

@SergeyKanzhelev SergeyKanzhelev moved this from Triage to PRs - Needs Reviewer in SIG Node CI/Test Board Feb 8, 2023
ffromani
ffromani reviewed Feb 8, 2023
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor(ish) question inside
Do we need to add/extend a e2e test to check these metrics are actually populated?

pkg/kubelet/metrics/metrics.go Outdated Show resolved Hide resolved
@bart0sh
Copy link
Contributor

bart0sh commented Feb 9, 2023

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 9, 2023
@bart0sh bart0sh added this to Needs Reviewer in SIG Node PR Triage Feb 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f5b92ef5f03b9d56c7bf101bb6e99459a77f6641

@bart0sh bart0sh moved this from Waiting on Author to Needs Approver in SIG Node PR Triage Feb 14, 2023
@swatisehgal
Copy link
Contributor Author

ah, great! In that case I'm good because I have no opinions about histogram settings or representation, and what you did LGTM to me.

Thanks!

Perhaps we may want to tune the histogram distributions but we can totally do that later.

Sure, I am happy to tweak these settings (in this PR or in a follow-up PR) if reviewers have an opinion about the distributions.

@swatisehgal
Copy link
Contributor Author

/assign @mrunalp @klueska
for approval

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@swatisehgal
node: topology-mgr: add metric to measure topology mgr admission latency
bc94163 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@swatisehgal
node: topology-mgr: e2e: changes to validate admission latency metrics
cf21dce 
The component was previously incorrect. This patch updates to
the correct component name.

Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@swatisehgal
node: topology-mgr: code optimization
8442b45 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@swatisehgal
Copy link
Contributor Author

/test pull-kubernetes-conformance-kind-ga-only-parallel

@klueska
Copy link
Contributor

klueska commented Feb 15, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4eda2d07b0bd53c27f0fcbff6e2f24b9d9152c40

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: klueska, SergeyKanzhelev, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit e18fa74 into kubernetes:master Feb 15, 2023
SIG Node CI/Test Board automation moved this from PRs - Needs Reviewer to Done Feb 15, 2023
SIG Node PR Triage automation moved this from Needs Approver to Done Feb 15, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 15, 2023
@swatisehgal swatisehgal deleted the topology-mgr-duration-metrics branch February 15, 2023 15:44
@ffromani ffromani mentioned this pull request Feb 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klueska klueska klueska left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@Random-Liu Random-Liu Awaiting requested review from Random-Liu

@bart0sh bart0sh Awaiting requested review from bart0sh

@ffromani ffromani Awaiting requested review from ffromani

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@mrunalp mrunalp

@klueska klueska

@bart0sh bart0sh

@ffromani ffromani

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node CI/Test Board
Done
SIG Node CI/Test Board
Archived in project
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

Node Topology Manager
7 participants
@swatisehgal @SergeyKanzhelev @bart0sh @ffromani @k8s-ci-robot @klueska @mrunalp