Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-693: Graduate Kubelet Topology Manager to GA #3745

Merged
merged 8 commits into from Feb 8, 2023
Merged

KEP-693: Graduate Kubelet Topology Manager to GA #3745

merged 8 commits into from Feb 8, 2023

Conversation

swatisehgal
Copy link
Contributor

@swatisehgal swatisehgal commented Jan 17, 2023 •
edited

  • One-line PR description: KEP-693: Graduate Kubelet Topology Manager to GA
  • Other comments:
  1. Initial Proposal to community repo: Add Topology Manager proposal. community#1680
  2. Proposal to the enhancement repo: Topology Manager KEP (Moving to new repo) #781
  3. KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/693-topology-manager

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Jan 17, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 17, 2023
@swatisehgal swatisehgal mentioned this pull request Jan 17, 2023
Closed
4 tasks
@swatisehgal swatisehgal force-pushed the topologymgr-ga-graduation branch 5 times, most recently from f85953e to 55f7f24 Compare January 17, 2023 18:42
@bart0sh
Copy link
Contributor

bart0sh commented Jan 19, 2023

/assign @klueska @derekwaynecarr

@bart0sh bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Jan 19, 2023
@wojtek-t wojtek-t mentioned this pull request Jan 24, 2023
Closed
11 tasks
@swatisehgal
node: topologymgr: port the proposal to latest KEP template
72c7052 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@swatisehgal
node: topologymgr: add PRR questionnaire
4aa0828 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@swatisehgal swatisehgal changed the title KEP-3741: Graduate Kubelet Topology Manager to GA KEP-693: Graduate Kubelet Topology Manager to GA Jan 24, 2023
@dchen1107 dchen1107 added this to the v1.27 milestone Jan 24, 2023
@ffromani
Copy link
Contributor

/cc

cici37
cici37 reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@cici37 cici37 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! PRR review shadow here. Have couple questions regarding with PRR section. Thanks :)

/cc @johnbelamaric for PRR approval

keps/sig-node/693-topology-manager/README.md Outdated Show resolved Hide resolved
keps/sig-node/693-topology-manager/README.md Outdated Show resolved Hide resolved
keps/sig-node/693-topology-manager/README.md Outdated Show resolved Hide resolved
keps/sig-node/693-topology-manager/README.md Outdated Show resolved Hide resolved
keps/sig-node/693-topology-manager/README.md Show resolved Hide resolved
@cici37
Copy link
Contributor

cici37 commented Jan 31, 2023

/cc @johnbelamaric for PRR approval

@k8s-ci-robot
Copy link
Contributor

@cici37: GitHub didn't allow me to request PR reviews from the following users: PRR, approval, for.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @johnbelamaric for PRR approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mrunalp
Copy link
Contributor

mrunalp commented Feb 8, 2023

Left one comment but looks fine overall from sig-node perspective.

/lgtm
/approve

cc: @dchen1107

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@swatisehgal
node: topologymgr: address PRR review comments (2)
2b861e2 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@johnbelamaric
Copy link
Member

Looks like Dawn's approval got cleared by tooling, but I am going to go ahead and approve it since that was clearly her intent.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2023
@johnbelamaric
Copy link
Member

Oh crap, I misread that message from mrunal. I'll ping Dawn directly to make sure she is OK with this.

@johnbelamaric
Copy link
Member

/hold for Dawn's approval

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 8, 2023
@swatisehgal
node: topologymgr: Address SIG node reviewers' review comments
fbf2eda 
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
SergeyKanzhelev
SergeyKanzhelev approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2023
@dchen1107
Copy link
Member

dchen1107 commented Feb 8, 2023 •
edited

/lgtm
/approve
/unhold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, johnbelamaric, mrunalp, SergeyKanzhelev, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dchen1107 dchen1107 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit bf11b9b into kubernetes:master Feb 8, 2023
SIG Node PR Triage automation moved this from Needs Reviewer to Done Feb 8, 2023
@swatisehgal
Copy link
Contributor Author

Thanks all for your reviews! Now I can go to bed :)

@swatisehgal swatisehgal deleted the topologymgr-ga-graduation branch February 8, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrunalp mrunalp mrunalp left review comments

@cici37 cici37 cici37 left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@ffromani ffromani Awaiting requested review from ffromani

Assignees

@mrunalp mrunalp

@klueska klueska

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

@johnbelamaric johnbelamaric

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
SIG Node PR Triage
Done
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet