Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ineligible endpoints yaml to include debug endpoints #115739

Merged

Conversation

heyste
Copy link
Member

@heyste heyste commented Feb 13, 2023

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The general view is that the following endpoints are for debug purposes only and shouldn't be part of conformance.
This PR would prevent these endpoints been show as conformance technical debt.

  • connectCoreV1GetNamespacedPodAttach
  • connectCoreV1GetNamespacedPodPortforward
  • connectCoreV1PostNamespacedPodAttach

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Release note:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

/sig architecture
/area conformance
/sig node

Adding the following endpoints
- connectCoreV1GetNamespacedPodPortforward
- connectCoreV1GetNamespacedPodAttach
- connectCoreV1PostNamespacedPodAttach
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/conformance Issues or PRs related to kubernetes conformance tests sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 13, 2023
@dims
Copy link
Member

dims commented Feb 13, 2023

/release-note-none
/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 13, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Feb 13, 2023
@heyste
Copy link
Member Author

heyste commented Feb 13, 2023

/test pull-kubernetes-e2e-gce
flake: [sig-storage] In-tree Volumes [Driver: hostPathSymlink] [Testpattern: Inline-volume (default fs)] subPath should support existing directory

{ failed [FAILED] while waiting for hostPath init pod to succeed: Timed out after 300.037s.

@heyste
Copy link
Member Author

heyste commented Feb 13, 2023

/test pull-kubernetes-conformance-image-test
Flake:

W0213 20:44:00.869] subprocess.CalledProcessError: Command '('bash', '-c', 'cd ./../../k8s.io/kubernetes && source ./../test-infra/experiment/kind-conformance-image-e2e.sh')' returned non-zero exit status 1.
E0213 20:44:00.869] Command failed
I0213 20:44:00.869] process 647 exited with code 1 after 23.4m
E0213 20:44:00.870] FAIL: pull-kubernetes-conformance-image-test 

@heyste
Copy link
Member Author

heyste commented Feb 13, 2023

/test pull-kubernetes-conformance-image-test

@Riaankl
Copy link
Contributor

Riaankl commented Feb 14, 2023

/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 14, 2023
@dims
Copy link
Member

dims commented Feb 14, 2023

consensus on slack:
https://kubernetes.slack.com/archives/C78F00H99/p1676398815869339

/approve

@smarterclayton
Copy link
Contributor

/lgtm

If we do find a situation where the conformance status of these endpoints is important, we will revisit within the conformance wg and use it as a test case for understanding what the bounds of conformance for workloads are.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8d0839b4d03b36a2337694cd909656fc60cbb680

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, heyste

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 731238f into kubernetes:master Feb 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants