New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubectl: add unit tests for kubectl debug profiles #115839
kubectl: add unit tests for kubectl debug profiles #115839
Conversation
Hi @wedaly. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Not a blocker for this PR but should probably have integration tests for these profiles too. Thanks for this work ❤️ ETA: Hopefully just as simple as slapping a couple extra lines onto the end of this file: |
dc43259
to
da1fd87
Compare
updated to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really minor nit but can you format the imports like:
standard libraries
remote libraries
k8s.io libraries
I know it wasn't part of your change but should be easy enough to get fixed up here and leaves things a little neater.
Unit test netadmin profile preserves existing capabilities. Unit test debug profiles in TestGenerateNodeDebugPod Unit test debug profiles in TestGeneratePodCopyWithDebugContainer Organize Go imports in unit tests Signed-off-by: Will Daly <widaly@microsoft.com>
da1fd87
to
21e8d29
Compare
Updated to organize Go imports in debug_test.go and profiles_test.go |
Thanks, really appreciate it :) |
LGTM label has been added. Git tree hash: 7afd0edb878d78d7d083b5ab2e12cda999d6e51d
|
/triage accepted I'm just a reviewer so I can't do final approval, so we'll have to wait on that, but this all looks great thanks again. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, wedaly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Followup to review comments in #115712
Unit test netadmin profile preserves existing capabilities.
Unit test debug profiles in TestGenerateNodeDebugPod
Unit test debug profiles in TestGeneratePodCopyWithDebugContainer
Which issue(s) this PR fixes:
xref kubernetes/kubectl#1108
followup from this comment: #115712
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: