cleanup(controller): use IsSuperset to avoid interim slice

[binacs]

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Use A.IsSuperset(B) instead of A.HasAll(B.List()) to avoid the overhead of interim slice and sorting in B.List().

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[binacs]

/retest

[pravarag]

Hi @binacs, do you have some existing issue which can be linked with this PR to understand the context. Since the changes seems to pretty small, I was wondering if these can be taken up along with some other major change?

[soltysh]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: eeb1f4fbb97a6fc40d1ee6dc0d0ccaa82ea2c271

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: binacs, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/OWNERS [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[soltysh]

/triage accepted
/priority backlog

[k8s-triage-robot]

The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass.

This bot retests PRs for certain kubernetes repos according to the following rules:

• The PR does have any do-not-merge/* labels
• The PR does not have the needs-ok-to-test label
• The PR is mergeable (does not have a needs-rebase label)
• The PR is approved (has cncf-cla: yes, lgtm, approved labels)
• The PR is failing tests required for merge

You can:

• Review the full test history for this PR
• Prevent this bot from retesting with /lgtm cancel or /hold
• Help make our tests less flaky by following our Flaky Tests Guide

/retest