New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add integration tests for debug profiles general & baseline #115909
add integration tests for debug profiles general & baseline #115909
Conversation
Hi @sding3. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig cli |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sding3 thanks for these tests, looks pretty good.
You need to add these new functions in here
kubernetes/test/cmd/legacy-script.sh
Line 1012 in 12c71fd
if kube::test::if_supports_resource "${pods}" ; then |
# Clean up | ||
kubectl delete pod target "${kube_flags[@]:?}" | ||
|
||
### Debug node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, it would be better to move these node tests into their own function or in
Line 95 in e0fedec
run_kubectl_debug_node_tests() { |
# Clean up | ||
kubectl delete pod target "${kube_flags[@]:?}" | ||
|
||
### Debug node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same above
set +o errexit | ||
} | ||
|
||
run_kubectl_debug_general_tests() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any specific reason not adding tests for restricted
?
/triage accepted |
383a087
to
1779053
Compare
@ardaguclu - thank you for your review. I've pushed update to address your comment. The reason why I didn't include tests for the restricted profile is due to #115672 haven't been merged yet. |
Thanks for these tests; /approve I'm deferring to @verb for the last tag. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, sding3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Nice test addition. /lgtm |
LGTM label has been added. Git tree hash: 2610c0bd0289400d711737640deb7db1bfe4aa02
|
The Kubernetes project has merge-blocking tests that are currently too flaky to consistently pass. This bot retests PRs for certain kubernetes repos according to the following rules:
You can:
/retest |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR adds integration tests for debug profiles general & baseline.
Integration tests help to reduce the chance of future regression.
Which issue(s) this PR fixes:
Updates #115287
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: